<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101843/">http://git.reviewboard.kde.org/r/101843/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2011, 8:52 p.m., <b>Sebastian Sauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- bool operator==(BaseIterator it)
+ bool operator==(BaseIterator it) const
While reading that part of the patch I was asking myself if there are compilers who would see those both methods as different and then jump in and generate the non-const one?
I don't remember any such thing in any C++ pitfall-doc but then I am not 100% sure so better ask to prevent us ending with something unwanted :)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look at the end of
http://www.cs.caltech.edu/courses/cs11/material/cpp/donnie/cpp-ops.html or
http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B
In fact, the operator should be
+ bool operator==(const BaseIterator &it) const
</pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On July 3rd, 2011, 6:17 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated July 3, 2011, 6:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Second and last const methods conversion.
the remaining methods that could be const are empty.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/KarbonCurveFit.cpp <span style="color: grey">(809ca13)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.h <span style="color: grey">(648ce2b)</span></li>
<li>kexi/webforms/model/Cache.h <span style="color: grey">(0ce376b)</span></li>
<li>kpresenter/part/pagelayout/KPrPlaceholder.h <span style="color: grey">(d4e7515)</span></li>
<li>kpresenter/part/pagelayout/KPrPlaceholder.cpp <span style="color: grey">(babbe35)</span></li>
<li>krita/image/tests/kis_random_generator_demo.h <span style="color: grey">(b76e492)</span></li>
<li>krita/image/tests/kis_random_generator_demo.cpp <span style="color: grey">(cc9b2c1)</span></li>
<li>krita/plugins/extensions/tonemapping/lib/kis_tone_mapping_operator.h <span style="color: grey">(ecce2c2)</span></li>
<li>krita/plugins/extensions/tonemapping/lib/kis_tone_mapping_operator.cc <span style="color: grey">(17d3ccc)</span></li>
<li>krita/plugins/paintops/dynadraw/filter.h <span style="color: grey">(7e8fd31)</span></li>
<li>krita/plugins/paintops/hairy/hairy_brush.h <span style="color: grey">(9664d3d)</span></li>
<li>krita/plugins/paintops/hairy/trajectory.h <span style="color: grey">(47541a2)</span></li>
<li>krita/plugins/paintops/spray/spray_brush.h <span style="color: grey">(a00faf4)</span></li>
<li>krita/plugins/tools/tool_curves/kis_curve_framework.h <span style="color: grey">(61c68ac)</span></li>
<li>krita/ui/widgets/newKisCurveWidget/curveWidget/kis_shared.h <span style="color: grey">(607bfec)</span></li>
<li>libs/kotext/changetracker/KoDeletedCellData.h <span style="color: grey">(2d02ff2)</span></li>
<li>libs/kotext/changetracker/KoDeletedCellData.cpp <span style="color: grey">(577b534)</span></li>
<li>libs/main/tests/rtreetestapp.h <span style="color: grey">(c319a3c)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathFormula.h <span style="color: grey">(a67fdc2)</span></li>
<li>plugins/vectorshape/libemf/BitmapHeader.h <span style="color: grey">(92ac3db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101843/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>