Review Request: Table of content for words

Lukáš Tvrdý lukast.dev at gmail.com
Tue Jan 25 13:22:30 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100421/
-----------------------------------------------------------

(Updated Jan. 25, 2011, 1:22 p.m.)


Review request for Calligra, Thorsten Zachmann and Casper Boemann.


Changes
-------

o fixing Zagges suggestions

Zagge, can you give me ship it, if you are ok with the code now? :)
Cheers


Summary
-------

This patch implements the loading of the part of the ODF that says how should be the 
table of content generated (table-of-content-source element with children).

Full loading is done, generation of the links is solved, navigation of the links works.

There are still some TODO's marked in the code. 
I think the development can continue in master as the solid ground is done.

This bug was closed as invalid through the development of this feature:
https://bugs.kde.org/show_bug.cgi?id=260542

Work done by Pavol Korinek and Lukas Tvrdy.


Diffs (updated)
-----

  libs/kotext/CMakeLists.txt 115966e 
  libs/kotext/KoTableOfContentsGeneratorInfo.h PRE-CREATION 
  libs/kotext/KoTableOfContentsGeneratorInfo.cpp PRE-CREATION 
  libs/kotext/KoText.h 6bfb176 
  libs/kotext/opendocument/KoTextLoader.h 3aba119 
  libs/kotext/opendocument/KoTextLoader.cpp e40d888 
  libs/kotext/opendocument/KoTextWriter.cpp 6567065 
  plugins/textshape/ToCGenerator.h 84747f1 
  plugins/textshape/ToCGenerator.cpp 3aa6a10 

Diff: http://git.reviewboard.kde.org/r/100421/diff


Testing
-------


Thanks,

Lukáš

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110125/8beaa92a/attachment.htm>


More information about the calligra-devel mailing list