Review Request: Table of content for words

Thorsten Zachmann t.zachmann at zagge.de
Tue Jan 25 09:21:33 GMT 2011



> On Jan. 24, 2011, 3:16 p.m., Thorsten Zachmann wrote:
> > libs/kotext/KoTableOfContentsGeneratorInfo.cpp, line 132
> > <http://git.reviewboard.kde.org/r/100421/diff/2/?file=7443#file7443line132>
> >
> >     can there be only one index-source-style? If so KoXml::namedItemNS can be used to get a specified child item
> 
> Lukáš Tvrdý wrote:
>     Sorry,I don't get it here. Can you rephrase?

In the foreach loop is it possible to have more then one index-source-style element? If there can be only one KoXml::namedItemNS can be used.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100421/#review1048
-----------------------------------------------------------


On Jan. 24, 2011, 1:44 p.m., Lukáš Tvrdý wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100421/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2011, 1:44 p.m.)
> 
> 
> Review request for Calligra, Thorsten Zachmann and Casper Boemann.
> 
> 
> Summary
> -------
> 
> This patch implements the loading of the part of the ODF that says how should be the 
> table of content generated (table-of-content-source element with children).
> 
> Full loading is done, generation of the links is solved, navigation of the links works.
> 
> There are still some TODO's marked in the code. 
> I think the development can continue in master as the solid ground is done.
> 
> This bug was closed as invalid through the development of this feature:
> https://bugs.kde.org/show_bug.cgi?id=260542
> 
> Work done by Pavol Korinek and Lukas Tvrdy.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt 115966e 
>   libs/kotext/KoTableOfContentsGeneratorInfo.h PRE-CREATION 
>   libs/kotext/KoTableOfContentsGeneratorInfo.cpp PRE-CREATION 
>   libs/kotext/KoText.h 6bfb176 
>   libs/kotext/opendocument/KoTextLoader.h 3aba119 
>   libs/kotext/opendocument/KoTextLoader.cpp e40d888 
>   libs/kotext/opendocument/KoTextWriter.cpp 6567065 
>   plugins/textshape/ToCGenerator.h 84747f1 
>   plugins/textshape/ToCGenerator.cpp 3aa6a10 
> 
> Diff: http://git.reviewboard.kde.org/r/100421/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110125/761ec999/attachment.htm>


More information about the calligra-devel mailing list