Review Request: Added creation and processing of a text style to format the number/bullet of a list.

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100306/#review790
-----------------------------------------------------------


If you convert a list like that is the file openable by OO and looks like in words?


filters/words/msword-odf/texthandler.cpp
<http://git.reviewboard.kde.org/r/100306/#comment590>

    How about giving the property directly in the function call.



filters/words/msword-odf/texthandler.cpp
<http://git.reviewboard.kde.org/r/100306/#comment589>

    The variable styleName is not needed you can just write
    
    return m_mainStyles->insert(...)



libs/kotext/styles/KoListLevelProperties.cpp
<http://git.reviewboard.kde.org/r/100306/#comment591>

    The check for  style.isNull() is not needed. style.attributeNS will return the default value when the style isNull.
    Please make the styleName a const variable.



libs/kotext/styles/KoListLevelProperties.cpp
<http://git.reviewboard.kde.org/r/100306/#comment592>

    isNull is not needed


- Thorsten


On Jan. 8, 2011, 8:13 p.m., Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100306/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 8:13 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Filter changes:
> * Let's use the style-name attribute of a list-level-style-* to point to a text style, which should be used to format the bullet/number of a list.
> * The style is stored into office:styles to be accessible via the style manager during layout.
> 
> KoListLevelProperties changes:
> * Lookup the referred style using the style manager and update the CharacterStyleId of the KoListStyle.
> 
> TODO:
> * If this approach is correct, also other filters should be updated.
> * Bullet sizes! 
> 
> 
> Diffs
> -----
> 
>   filters/words/msword-odf/texthandler.h 1465e66 
>   filters/words/msword-odf/texthandler.cpp b7d582c 
>   libs/kotext/styles/KoListLevelProperties.cpp ec5a472 
> 
> Diff: http://git.reviewboard.kde.org/r/100306/diff
> 
> 
> Testing
> -------
> 
> Using words application only, msword test documents containing numbered lists.
> 
> 
> Screenshots
> -----------
> 
> msword 2007
>   http://git.reviewboard.kde.org/r/100306/s/33/
> words
>   http://git.reviewboard.kde.org/r/100306/s/34/
> words patched
>   http://git.reviewboard.kde.org/r/100306/s/35/
> msword (list item sizes)
>   http://git.reviewboard.kde.org/r/100306/s/36/
> words (list item sizes)
>   http://git.reviewboard.kde.org/r/100306/s/37/
> 
> 
> Thanks,
> 
> Matus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110109/8795ad62/attachment.htm>