<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100306/">http://git.reviewboard.kde.org/r/100306/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you convert a list like that is the file openable by OO and looks like in words?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100306/diff/3/?file=6399#file6399line1469" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/msword-odf/texthandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KWordTextHandler::createBulletStyle(const QString& textStyleName) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1469</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">prop</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"fo:color"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about giving the property directly in the function call.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100306/diff/3/?file=6399#file6399line1496" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/msword-odf/texthandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KWordTextHandler::createBulletStyle(const QString& textStyleName) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1496</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">styleName</span> <span class="o">=</span> <span class="n">m_mainStyles</span><span class="o">-></span><span class="n">insert</span><span class="p">(</span><span class="n">style</span><span class="p">,</span> <span class="n">QString</span><span class="p">(</span><span class="s">"T"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The variable styleName is not needed you can just write
return m_mainStyles->insert(...)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100306/diff/3/?file=6400#file6400line386" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/styles/KoListLevelProperties.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoListLevelProperties::loadOdf(KoShapeLoadingContext& scontext, const KoXmlElement& style)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">386</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">styleName</span> <span class="o">=</span> <span class="n">style</span><span class="p">.</span><span class="n">isNull</span><span class="p">()</span> <span class="o">?</span> <span class="n">QString</span><span class="p">()</span> <span class="o">:</span> <span class="n">style</span><span class="p">.</span><span class="n">attributeNS</span><span class="p">(</span><span class="n">KoXmlNS</span><span class="o">::</span><span class="n">text</span><span class="p">,</span> <span class="s">"style-name"</span><span class="p">,</span> <span class="n">QString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The check for style.isNull() is not needed. style.attributeNS will return the default value when the style isNull.
Please make the styleName a const variable.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100306/diff/3/?file=6400#file6400line472" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/styles/KoListLevelProperties.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoListLevelProperties::loadOdf(KoShapeLoadingContext& scontext, const KoXmlElement& style)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">472</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">size</span> <span class="o">=</span> <span class="n">style</span><span class="p">.</span><span class="n">isNull</span><span class="p">()</span> <span class="o">?</span> <span class="n">QString</span><span class="p">()</span> <span class="o">:</span> <span class="n">style</span><span class="p">.</span><span class="n">attributeNS</span><span class="p">(</span><span class="n">KoXmlNS</span><span class="o">::</span><span class="n">text</span><span class="p">,</span> <span class="s">"bullet-relative-size"</span><span class="p">,</span> <span class="n">QString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isNull is not needed</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On January 8th, 2011, 8:13 p.m., Matus Uzak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Matus Uzak.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2011, 8:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Filter changes:
* Let's use the style-name attribute of a list-level-style-* to point to a text style, which should be used to format the bullet/number of a list.
* The style is stored into office:styles to be accessible via the style manager during layout.
KoListLevelProperties changes:
* Lookup the referred style using the style manager and update the CharacterStyleId of the KoListStyle.
TODO:
* If this approach is correct, also other filters should be updated.
* Bullet sizes! </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using words application only, msword test documents containing numbered lists.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/msword-odf/texthandler.h <span style="color: grey">(1465e66)</span></li>
<li>filters/words/msword-odf/texthandler.cpp <span style="color: grey">(b7d582c)</span></li>
<li>libs/kotext/styles/KoListLevelProperties.cpp <span style="color: grey">(ec5a472)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100306/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100306/s/33/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/08/msword_2007_400x100.png" style="border: 1px black solid;" alt="msword 2007" /></a>
<a href="http://git.reviewboard.kde.org/r/100306/s/34/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/08/words_400x100.png" style="border: 1px black solid;" alt="words" /></a>
<a href="http://git.reviewboard.kde.org/r/100306/s/35/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/08/words_patched_400x100.png" style="border: 1px black solid;" alt="words patched" /></a>
<a href="http://git.reviewboard.kde.org/r/100306/s/36/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/08/msword_list_item_sizes_400x100.png" style="border: 1px black solid;" alt="msword (list item sizes)" /></a>
<a href="http://git.reviewboard.kde.org/r/100306/s/37/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/08/words_list_item_sizes_400x100.png" style="border: 1px black solid;" alt="words (list item sizes)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>