Review Request: Fixes bug 264143

[Matus Uzak]

> On Feb. 22, 2011, 4:13 p.m., Boudewijn Rempt wrote:
> > Quick note: it seems to improve the bullets in an odt imported from oowriter as well. They were too big, and look fine with the patch.

Sure it did, we were using the default KoCharacterStyle in many cases because we are not loading the text-properties child element of list-level-style-* yet (present in OOo outputs).  
But you can't generalize that it's better now, each font family has a specific bullet character. ;)

The proper solution is to use the corresponding bullet character of the font.
 
This patch avoids using the defaults and from this point of view it's fine!  But we should avoid using constants like 0.707.  Who cares if the bullet is too big or too small if we don't have the corresponding character in the font (At least something is drawn there).  Any examples for such a font? 


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100679/#review1583
-----------------------------------------------------------


On Feb. 20, 2011, 4:59 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100679/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 4:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixes bug 264143 and does a better handling of bullet sizes for list item having different styles.
> 
> 
> This addresses bug 264143.
>     http://bugs.kde.org/show_bug.cgi?id=264143
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.h d531b96 
>   libs/kotext/styles/KoParagraphStyle.cpp 4ca34b0 
>   plugins/textshape/Layout.cpp 674cb23 
> 
> Diff: http://git.reviewboard.kde.org/r/100679/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110222/0bd74be7/attachment.htm>