<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100679/">http://git.reviewboard.kde.org/r/100679/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2011, 4:13 p.m., <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quick note: it seems to improve the bullets in an odt imported from oowriter as well. They were too big, and look fine with the patch.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure it did, we were using the default KoCharacterStyle in many cases because we are not loading the text-properties child element of list-level-style-* yet (present in OOo outputs).
But you can't generalize that it's better now, each font family has a specific bullet character. ;)
The proper solution is to use the corresponding bullet character of the font.
This patch avoids using the defaults and from this point of view it's fine! But we should avoid using constants like 0.707. Who cares if the bullet is too big or too small if we don't have the corresponding character in the font (At least something is drawn there). Any examples for such a font? </pre>
<br />
<p>- Matus</p>
<br />
<p>On February 20th, 2011, 4:59 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2011, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes bug 264143 and does a better handling of bullet sizes for list item having different styles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=264143">264143</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(d531b96)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(4ca34b0)</span></li>
<li>plugins/textshape/Layout.cpp <span style="color: grey">(674cb23)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100679/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>