Review Request: Fixes bug 264143

[Gopalakrishna Bhat]

> On Feb. 21, 2011, 1:09 p.m., Matus Uzak wrote:
> > Please sync with Lukas Tvrdy, he has already a patch for loading of text-properties from the lists-level-style-* element.

I just pinged Lukas on IRC and he told that he will look into this patch later.


> On Feb. 21, 2011, 1:09 p.m., Matus Uzak wrote:
> > plugins/textshape/Layout.cpp, line 1984
> > <http://git.reviewboard.kde.org/r/100679/diff/1/?file=9483#file9483line1984>
> >
> >     Both MS Office and TeX use minimum here.

A single list item might have different styles with different font sizes, so this is necessary. I just checked in MS Office and OO both position the bullets at the center of the list item and they use the max font size to calculate the position.


> On Feb. 21, 2011, 1:09 p.m., Matus Uzak wrote:
> > plugins/textshape/Layout.cpp, line 2055
> > <http://git.reviewboard.kde.org/r/100679/diff/1/?file=9483#file9483line2055>
> >
> >     This one is tricky.  You will never find the correct constants to make it look nice because it's font specific.  We should definitely use the corresponding character of the font.  Its designer already did the job.  Lukas Tvrdy is already working on it. 
> >     
> >     As soon we will use the character, only the following has to be reused from the KoCharacterStyle inherited from the block: font-family, font-size, color.  It makes no sense to apply font-weight, text-underline-type, etc.

The original calculation placed the painter y-position at the baseline of the font text and then moved it using y-=width/10 which made the bullet off center at larger font sizes. The new approach is for that purpose. If Lukas is also working on it we can merge our efforts.


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100679/#review1553
-----------------------------------------------------------


On Feb. 20, 2011, 4:59 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100679/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 4:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixes bug 264143 and does a better handling of bullet sizes for list item having different styles.
> 
> 
> This addresses bug 264143.
>     http://bugs.kde.org/show_bug.cgi?id=264143
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.h d531b96 
>   libs/kotext/styles/KoParagraphStyle.cpp 4ca34b0 
>   plugins/textshape/Layout.cpp 674cb23 
> 
> Diff: http://git.reviewboard.kde.org/r/100679/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110222/a455aef4/attachment.htm>