Review Request: Fixes bug 264143

[Matus Uzak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100679/#review1553
-----------------------------------------------------------


Please sync with Lukas Tvrdy, he has already a patch for loading of text-properties from the lists-level-style-* element.


libs/kotext/styles/KoParagraphStyle.cpp
<http://git.reviewboard.kde.org/r/100679/#comment1337>

    Not sure about this one, can someone else check it (Casper, Sebastian)  



plugins/textshape/Layout.cpp
<http://git.reviewboard.kde.org/r/100679/#comment1336>

    In case the bullet/number formatting is not provided by the lists-level-style-* element, the text:style-name attribute to be specific or the style:text-properties child element, this would be fine.



plugins/textshape/Layout.cpp
<http://git.reviewboard.kde.org/r/100679/#comment1334>

    Both MS Office and TeX use minimum here.



plugins/textshape/Layout.cpp
<http://git.reviewboard.kde.org/r/100679/#comment1335>

    This one is tricky.  You will never find the correct constants to make it look nice because it's font specific.  We should definitely use the corresponding character of the font.  Its designer already did the job.  Lukas Tvrdy is already working on it. 
    
    As soon we will use the character, only the following has to be reused from the KoCharacterStyle inherited from the block: font-family, font-size, color.  It makes no sense to apply font-weight, text-underline-type, etc.


- Matus


On Feb. 20, 2011, 4:59 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100679/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 4:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixes bug 264143 and does a better handling of bullet sizes for list item having different styles.
> 
> 
> This addresses bug 264143.
>     http://bugs.kde.org/show_bug.cgi?id=264143
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.h d531b96 
>   libs/kotext/styles/KoParagraphStyle.cpp 4ca34b0 
>   plugins/textshape/Layout.cpp 674cb23 
> 
> Diff: http://git.reviewboard.kde.org/r/100679/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110221/7ee3e4d5/attachment.htm>