Review Request: Limit zooming to a minimum and maximum zoom value

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1325
-----------------------------------------------------------



libs/widgets/KoZoomAction.cpp
<http://git.reviewboard.kde.org/r/100613/#comment1097>

    Couldn't we create a constant == 16 and use it everywhere is this code instead of 16 and (constant-1) instead of 15?


- Jarosław


On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2011, 12:45 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting the minimum and maximum zoom levels. Currently it is possible to completely freeze Tables (or cause even more serious issues) by zoom out far enough.
> Zooming in on the other hand can cause you to get completely lost in your document.
> 
> Note that for Krita and others, the default minimum and maximum zoom might not be the best choice, which is why I included a setter for the minimum and maximum values.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoZoomAction.cpp 4ef4d8b 
>   libs/widgets/KoZoomController.cpp 54b9168 
>   libs/widgets/KoZoomHandler.cpp ce234e6 
>   libs/widgets/KoZoomMode.h 9bfd195 
>   libs/widgets/KoZoomMode.cpp 293f1af 
> 
> Diff: http://git.reviewboard.kde.org/r/100613/diff
> 
> 
> Testing
> -------
> 
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the zoom handler unit test, which I will fix after this.
> 
> 
> Thanks,
> 
> Arjen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110209/3e7f0c25/attachment.htm>