Review Request:

[Casper Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100522/#review1152
-----------------------------------------------------------


it looks okay to me. i noted a few TODOs that you might want to fix/investigate first though. just to avoid nasty surprises later

I've also not tested it, just looked at the code

- Casper


On Feb. 2, 2011, 5:53 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100522/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 5:53 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch implements text on shape using inheritance. It fixes various problems of the existing design.                                                                                     
>                                                                                                                                                                                               
> Following problems are fixed:                                                                                                                                                                 
> - Rotated shapes with have text BUG: 231686 (fixed the wrong rotation)                                                                                                                        
> - Placing of connections with text BUG: 251528                                                                                                                                                
> - Not longer able to change the color of a shape with text                                                                                                                                    
> - Update Text position if the path of a path shape changes                                                                                                                                    
>   This also fixes the problem that the bounding rect of a path shape was not updated correctly when it has text                                                                               
> - Fix anchoring in words to shapes with text                                                                                                                                                  
> - Event listeners no longer working for shapes with text                                                                                                                                      
> - Animations with shapes no longer working for shapes with text                                                                                                                               
>                                                                                                                                                                                               
> It might fix some other unnoticed bugs that are caused due to getting a tos container instead the actual shape.
> 
> 
> This addresses bugs 231686 and 251528.
>     http://bugs.kde.org/show_bug.cgi?id=231686
>     http://bugs.kde.org/show_bug.cgi?id=251528
> 
> 
> Diffs
> -----
> 
>   libs/flake/CMakeLists.txt 603f7cd 
>   libs/flake/KoConnectionShape.cpp aeee6f7 
>   libs/flake/KoPathShape.h 2807cc5 
>   libs/flake/KoPathShape.cpp 86fbac9 
>   libs/flake/KoPathShape_p.h 0c04666 
>   libs/flake/KoShapeContainer.h de24b90 
>   libs/flake/KoShapeContainer.cpp a3683d6 
>   libs/flake/KoTextOnShapeContainer.h 85a4219 
>   libs/flake/KoTextOnShapeContainer.cpp 07921ca 
>   libs/flake/KoTosContainer.h PRE-CREATION 
>   libs/flake/KoTosContainer.cpp PRE-CREATION 
>   libs/flake/KoTosContainerModel.h PRE-CREATION 
>   libs/flake/KoTosContainerModel.cpp PRE-CREATION 
>   libs/flake/KoTosContainer_p.h PRE-CREATION 
>   plugins/pathshapes/ellipse/EllipseShape.cpp f65cfdc 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp ad7cdac 
>   plugins/pathshapes/rectangle/RectangleShape.cpp a31ba13 
>   plugins/pathshapes/star/StarShape.cpp d299ea3 
>   plugins/pictureshape/PictureShape.h 2fb79c8 
>   plugins/pictureshape/PictureShape.cpp 560f797 
>   plugins/treeshape/Layout.h c44451b 
>   plugins/treeshape/Layout.cpp 48b04ba 
>   plugins/treeshape/TreeShape.cpp 2605770 
>   plugins/treeshape/TreeShapeMoveStrategy.cpp 289d1d2 
>   words/part/KWView.h efb775a 
>   words/part/KWView.cpp 376c33f 
>   words/part/words.rc 774dbce 
> 
> Diff: http://git.reviewboard.kde.org/r/100522/diff
> 
> 
> Testing
> -------
> 
> Tested various documents and they all work. All of the above also have been verified to work with the changes.
> 
> 
> Thanks,
> 
> Thorsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110202/470d362c/attachment.htm>