<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100522/">http://git.reviewboard.kde.org/r/100522/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it looks okay to me. i noted a few TODOs that you might want to fix/investigate first though. just to avoid nasty surprises later
I've also not tested it, just looked at the code</pre>
<br />
<p>- Casper</p>
<br />
<p>On February 2nd, 2011, 5:53 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2011, 5:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements text on shape using inheritance. It fixes various problems of the existing design.
Following problems are fixed:
- Rotated shapes with have text BUG: 231686 (fixed the wrong rotation)
- Placing of connections with text BUG: 251528
- Not longer able to change the color of a shape with text
- Update Text position if the path of a path shape changes
This also fixes the problem that the bounding rect of a path shape was not updated correctly when it has text
- Fix anchoring in words to shapes with text
- Event listeners no longer working for shapes with text
- Animations with shapes no longer working for shapes with text
It might fix some other unnoticed bugs that are caused due to getting a tos container instead the actual shape.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested various documents and they all work. All of the above also have been verified to work with the changes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=231686">231686</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=251528">251528</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(603f7cd)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(aeee6f7)</span></li>
<li>libs/flake/KoPathShape.h <span style="color: grey">(2807cc5)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(86fbac9)</span></li>
<li>libs/flake/KoPathShape_p.h <span style="color: grey">(0c04666)</span></li>
<li>libs/flake/KoShapeContainer.h <span style="color: grey">(de24b90)</span></li>
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(a3683d6)</span></li>
<li>libs/flake/KoTextOnShapeContainer.h <span style="color: grey">(85a4219)</span></li>
<li>libs/flake/KoTextOnShapeContainer.cpp <span style="color: grey">(07921ca)</span></li>
<li>libs/flake/KoTosContainer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoTosContainer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoTosContainerModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoTosContainerModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoTosContainer_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShape.cpp <span style="color: grey">(f65cfdc)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span style="color: grey">(ad7cdac)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShape.cpp <span style="color: grey">(a31ba13)</span></li>
<li>plugins/pathshapes/star/StarShape.cpp <span style="color: grey">(d299ea3)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(2fb79c8)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(560f797)</span></li>
<li>plugins/treeshape/Layout.h <span style="color: grey">(c44451b)</span></li>
<li>plugins/treeshape/Layout.cpp <span style="color: grey">(48b04ba)</span></li>
<li>plugins/treeshape/TreeShape.cpp <span style="color: grey">(2605770)</span></li>
<li>plugins/treeshape/TreeShapeMoveStrategy.cpp <span style="color: grey">(289d1d2)</span></li>
<li>words/part/KWView.h <span style="color: grey">(efb775a)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(376c33f)</span></li>
<li>words/part/words.rc <span style="color: grey">(774dbce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100522/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>