Review Request: use the paint device directly instead of a byte array to create selection outlins

Boudewijn Rempt boud at valdyas.org
Tue Dec 27 12:30:20 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103552/
-----------------------------------------------------------

Review request for Calligra and Sven Langkamp.


Description
-------

The outline generator is used in two places: to create brush outlines and to create outlines for selections. It works on a raw byte array. For selections, that array can be very big. This patch adds a version of the outline generator that works on paint devices. For optimization, the random accessor is shared. The paint device version also doesn't use a width * height char array for the marks, but a paint device. This saves memory because paint devices are sparse by nature.


This addresses bug 285775.
    http://bugs.kde.org/show_bug.cgi?id=285775


Diffs
-----

  krita/image/kis_outline_generator.h e238183 
  krita/image/kis_outline_generator.cpp 366d394 
  krita/image/kis_pixel_selection.cpp 3c16efc 

Diff: http://git.reviewboard.kde.org/r/103552/diff/diff


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111227/9b01ab33/attachment.htm>


More information about the calligra-devel mailing list