Review Request: Clean a bit calligraconverter.cpp
Commit Hook
null at kde.org
Mon Dec 19 16:49:48 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103413/#review9085
-----------------------------------------------------------
This review has been submitted with commit 33769ea47fa3770107c84f2c033b3d4459b51d3d by Alex Fiestas to branch master.
- Commit Hook
On Dec. 14, 2011, 7:28 p.m., Alex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103413/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2011, 7:28 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Cleaned a little bit calligraconverter.cpp by applying some general code clean concepts such:
> Return early
> Return on errors
> Do one thing on each function
>
> Is not much change but I think makes code clearer with less indentation etc.
>
>
> Diffs
> -----
>
> tools/converter/calligraconverter.cpp 1baea00
>
> Diff: http://git.reviewboard.kde.org/r/103413/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111219/f03a94fc/attachment.htm>
More information about the calligra-devel
mailing list