Review Request: Clean a bit calligraconverter.cpp

[Alex Fiestas]

> On Dec. 15, 2011, 8:34 a.m., Thorsten Zachmann wrote:
> > tools/converter/calligraconverter.cpp, lines 140-141
> > <http://git.reviewboard.kde.org/r/103413/diff/1/?file=43376#file43376line140>
> >
> >     The i18n call needs to be removed as we are in stringfreeze at the moment. Please add a comment that it should be changed after 2.4 is released.

The i18n was already there I only move it so no i18n freeze is break (it was on line 172 now it is on 126).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103413/#review8966
-----------------------------------------------------------


On Dec. 14, 2011, 7:28 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103413/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2011, 7:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Cleaned a little bit calligraconverter.cpp by applying some general code clean concepts such:
> Return early
> Return on errors
> Do one thing on each function
> 
> Is not much change but I think makes code clearer with less indentation etc.
> 
> 
> Diffs
> -----
> 
>   tools/converter/calligraconverter.cpp 1baea00 
> 
> Diff: http://git.reviewboard.kde.org/r/103413/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111219/70ff7817/attachment.htm>