Review Request: Explicitly accept mouse event on canvas level to prevent move window around

Boudewijn Rempt boud at valdyas.org
Tue Dec 13 15:01:23 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103392/#review8922
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On Dec. 12, 2011, 10:42 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103392/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2011, 10:42 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In oxygen and bespin widget style, drag any part of the window will move window around, but our user may accidently do that on canvas by mistake or when a shape is locked, so we should explicitly accept mouse press event to prevent a drag event sent to parent widget.
> 
> 
> Diffs
> -----
> 
>   braindump/src/Canvas.cpp 92b34de 
>   karbon/ui/widgets/KarbonCanvas.cpp 172662c 
>   krita/ui/canvas/kis_canvas_widget_base.cpp 04395ff 
>   libs/kopageapp/KoPACanvas.cpp 7b8fb83 
>   words/part/KWCanvas.cpp 7561b4f 
> 
> Diff: http://git.reviewboard.kde.org/r/103392/diff/diff
> 
> 
> Testing
> -------
> 
> No problem found but dragging on the gray region in Words, don't know how to fix that.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111213/67ec5a98/attachment.htm>


More information about the calligra-devel mailing list