Review Request: Fix for Words crashes on picking "Blank Document" in template dialog with one document already open.

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102242/#review5494
-----------------------------------------------------------

Ship it!


Just fantastic :-)

- Sebastian


On Aug. 7, 2011, 10:37 a.m., Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102242/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 10:37 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Not one hundred percent sure this is the best way to fix this, but it is that best I could come up with.
> 
> The crash occurs due to tool options docker trying to access widgets that's already been deleted. To avoid this I reset the widgets in the tool options dialog when a new document is loaded.
> 
> 
> This addresses bug 272410.
>     http://bugs.kde.org/show_bug.cgi?id=272410
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDockerManager.h 6e71db6 
>   libs/main/KoDockerManager.cpp c893980 
>   libs/main/KoMainWindow.cpp c629827 
>   libs/main/KoToolDocker.cpp 425497c 
>   libs/main/KoToolDocker_p.h e7c373b 
> 
> Diff: http://git.reviewboard.kde.org/r/102242/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110808/0b8eb3e1/attachment.htm>