Review Request: Fix for Words crashes on picking "Blank Document" in template dialog with one document already open.

Peter Simonsson peter.simonsson at gmail.com
Sun Aug 7 11:37:36 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102242/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

Not one hundred percent sure this is the best way to fix this, but it is that best I could come up with.

The crash occurs due to tool options docker trying to access widgets that's already been deleted. To avoid this I reset the widgets in the tool options dialog when a new document is loaded.


This addresses bug 272410.
    http://bugs.kde.org/show_bug.cgi?id=272410


Diffs
-----

  libs/main/KoDockerManager.h 6e71db6 
  libs/main/KoDockerManager.cpp c893980 
  libs/main/KoMainWindow.cpp c629827 
  libs/main/KoToolDocker.cpp 425497c 
  libs/main/KoToolDocker_p.h e7c373b 

Diff: http://git.reviewboard.kde.org/r/102242/diff


Testing
-------


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110807/3609eb16/attachment.htm>


More information about the calligra-devel mailing list