Regressions

[Sebastian Sauer]

Thanks for discovering.

Thorsten Zachmann wrote:
> 2. Problems with shape positions introduced in
> commit 4104ab4dc622b2390b22072dcc49d9c3596f23f1
> Author: Sebastian Sauer <sebastian.sauer at kdab.com>
> Date:   Thu Jul 28 12:04:21 2011 +0200
> 
>     Fix infinite layout-loop
>     see http://git.reviewboard.kde.org/r/102097/#review5132
>     REVIEW:102097
> 
> With that different shapes are now placed incorrectly

hmmm... sounds like my favorite, the anchors, are back. We have a problem with them anyways cause once a relayout is triggered they are wrong. 
Will look why that is so / how to proper fix.

>  
http://www.zagge.de/anchor/regressions_110731/66.99.14%2530.4%2530%252FGHS%252Fkdonohoo%252Ffiles%252FAnalyzing_DNA_Fingerpri
nts.docx
> 
http://www.zagge.de/anchor/regressions_110731/acsliteracy.wikispaces.com%252Ffile%252Fview%252FCause+and+Effect+Lesson+The+Day+Ji
mmy%2527s+Boa.docx
> 
http://www.zagge.de/anchor/regressions_110731/aderholt.house.gov%252Fuploads%252FHAC%2520FY11%2520Member%2520Request%2520F
orm%2520with%2520instructions.doc.docx
> http://www.zagge.de/anchor/regressions_110731/admin.state.nh.us%252Fhr%252Fdocuments%252FSESANominationForm.doc
> http://www.zagge.de/anchor/regressions_110731/amweb.pbworks.com%252Ff%252FMy+Yearling+Journal.docx
> 
> 3. With that some text gets clipped and is no longer visible:
> commit d85d4aef446c9f8c3eb5b4ba9a6dd96c6e74ea55
> Author: Sebastian Sauer <sebastian.sauer at kdab.com>
> Date:   Thu Jul 28 12:05:40 2011 +0200
> 
>     Fix text clipping
>     see http://git.reviewboard.kde.org/r/102100/
>     BUG:273177
>     REVIEW:102100
> 
> http://www.zagge.de/anchor/regressions_110731/agwater.okstate.edu%252Fproposals%252FPenn_InHouse%2520Windrowing.docx
> http://www.zagge.de/anchor/regressions_110731/ally.ru%252Fmil%252Ffiles%252Frecipe_for_murder.docx

Yes, this commit and the reverted 39f1555 belong logical together (see bug 273177). So, if the one is reverted the other needs to be too. Done now.

That brings me to the essential question if 39f1555 was reverted cause the test was done with this commit excluded (I wasn#t able to reproduce the 
test-result with this patch included)? Will look.

> 4. Some documents trigger the new added asserts added in:
> commit 9dab3746eed8c6b3ed54643244ee0f3f81553882
> Author: Sebastian Sauer <sebastian.sauer at kdab.com>
> Date:   Fri Jul 29 17:15:32 2011 +0200
> 
>     Added two more asserts to be sure that arn't the reason for crash-bug
> 278682
> 
> 
http://www.zagge.de/anchor/regressions_110731/wiki.documentfoundation.org%252Fcgi_img_auth.php%252Fc%252Fce%252F%25302%25305W
G3-
> PrintingExportingEmailing.odt
> 
http://www.zagge.de/anchor/regressions_110731/wiki.services.openoffice.org%252Fw%252Fimages%252F9%252F91%252F%25305%25308IG3-
> SlidesNotesHandouts.odt

Great. That explains the crash-bug 278682 and is exactly what I was hoping for. Thanks :-)