sort of review request

[Boudewijn Rempt]

Hi,

I spendt time last week cleaning up the use of KoToolSelection as the basis for KoTextEditor. KoTextEditor used to be called KoTextSelectionHandler, but right now is more a generic interface to the cursor associated with a particular QTextDocument owned by a particular shape.

So instead of activating the text tool to select the KoToolSelection and cast it into KoTextEditor, I've created a convenience method to check whether there is a shape that has a QTextDocument selected on a particular canvas and get the editor from there. 

I've attached the patchset to this mail because putting everything on reviewboard will be confusing, I fear -- there's quite a few changes in here and the order of the patches shows the way I developed the code more than just the whole change in one go. Some parts of this change have already been pushed, like the code to hide KoToolSelection::hasSelection behind the KoToolBase and KoToolProxy.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-commented-out-bit-of-code-from-ApplicationCon.patch
Type: text/x-patch
Size: 1356 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-update-copyright.patch
Type: text/x-patch
Size: 867 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Index-marker-insert-using-the-shape-selection-not-th.patch
Type: text/x-patch
Size: 4579 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Insert-Semantic-Object-don-t-get-the-text-editor-fro.patch
Type: text/x-patch
Size: 1847 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-RdfSemanticTreeWidget-use-the-selection-s-text-shape.patch
Type: text/x-patch
Size: 1753 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Do-not-return-the-KoInlineObject-after-all-from-Inse.patch
Type: text/x-patch
Size: 1347 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Disable-autoupdating-for-the-rdf-docker.patch
Type: text/x-patch
Size: 1526 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Follow-the-KoTextSelectionHander-to-KoTextEditor-ref.patch
Type: text/x-patch
Size: 2099 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-KoTextEditor-add-convenience-function-to-retrieve-th.patch
Type: text/x-patch
Size: 3103 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Use-KoTextEditor-getTextEditorFromCanvas-convenience.patch
Type: text/x-patch
Size: 2751 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-TextPasteCommand-don-t-switch-to-the-text-tool-just-.patch
Type: text/x-patch
Size: 1472 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-remove-obsolete-header.patch
Type: text/x-patch
Size: 715 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-KoRdfSemanticItem-use-KoTextEditor-getTextEditorFrom.patch
Type: text/x-patch
Size: 3385 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-Remove-KoDocumentRdf-ensureTextTool.patch
Type: text/x-patch
Size: 4191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-Create-a-TextToolSelection-KoToolSelection-class.patch
Type: text/x-patch
Size: 3613 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-remove-obsolete-warning.patch
Type: text/x-patch
Size: 949 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-use-KoTextEditor-getEditorFromCanvas-Get-the-KoTextE.patch
Type: text/x-patch
Size: 6643 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-RDF-use-KoTextEditor-getEditorFromCanvas-api.patch
Type: text/x-patch
Size: 2870 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-Remove-unused-KoTextEditor-editor-method-from-KWRdDo.patch
Type: text/x-patch
Size: 1409 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020-Remove-unused-editor-virtual-method-from-InsertSeman.patch
Type: text/x-patch
Size: 4460 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021-KoTextEditor-is-no-longer-a-KoToolSelection.patch
Type: text/x-patch
Size: 1774 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022-use-convenience-method-to-get-KoTextEditor-instead-o.patch
Type: text/x-patch
Size: 1139 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023-Don-t-expose-the-KoToolSelection-object-through-KoTo.patch
Type: text/x-patch
Size: 1412 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/f4525c68/attachment-0022.bin>