Review-request: Fix shapes are not deleted in KPresenter

[Thorsten Zachmann]

Hello Sebastian,

On Thursday, April 21, 2011 15:29:21 Sebastian Sauer wrote:
> Boudewijn Rempt wrote:
> > On Wednesday 20 April 2011 Apr, Sebastian Sauer wrote:
> >> Please see attached patch which fixes
> >> Crash is observed while opening the attached ppt file
> >> https://bugs.kde.org/show_bug.cgi?id=270960
> >> and is the followup to the "deleting children of KoShapeContainer"
> >> thread.
> >> 
> >> ok to commit?
> > 
> > Are you sure there's only ever one layer on a page?
> 
> Well, that's the one layer added in the ctor of the class. It may the case
> that there are other places that add shapes/layers/containers and don't
> delete them later on too. In any case I think just deleting them all would
> be a mistake cause
> 1) that may introduce regressions and
> 2) it's probably the wrong place and it should be done at the same place
> the shapes are created/added to keep logic together.

Patch looks good but all layers need to be deleted as Boudewijn has pointed 
out. The is no other code that does the deleting of the layers so this is the 
right place. The place where they are created cannot handle it.

Out of curiosity, what is the reason that problems are seen with the new 
layout code?

Thorsten