Review-request: Fix shapes are not deleted in KPresenter

[Sebastian Sauer]

Boudewijn Rempt wrote:
> On Wednesday 20 April 2011 Apr, Sebastian Sauer wrote:
>> Please see attached patch which fixes
>> Crash is observed while opening the attached ppt file
>> https://bugs.kde.org/show_bug.cgi?id=270960
>> and is the followup to the "deleting children of KoShapeContainer"
>> thread.
>> 
>> ok to commit?
>> 
> 
> Are you sure there's only ever one layer on a page?
 
Well, that's the one layer added in the ctor of the class. It may the case 
that there are other places that add shapes/layers/containers and don't delete 
them later on too. In any case I think just deleting them all would be a 
mistake cause
1) that may introduce regressions and
2) it's probably the wrong place and it should be done at the same place the 
shapes are created/added to keep logic together.

In any case I am sure there are still things created that are not deleted 
cause that's what those
** (process:555): WARNING **: 1 dictionaries weren't free'd.
that got printed if you exit kpresenter, indicates. Well, step by step.