Issues found while packaging

[Will Stephenson]

Hi all

I recently packaged Calligra Mobile for Plasma Active, and our tests and my 
observations show the following issues:

Summary:
1) wrongly sized icons
2) .desktop files using shebangs for execution by xdg-open
3) kexi does not install its app icons in hicolor so that non-Oxygen using 
environments can show it in app launchers
4) Potential partial installs of components in mobile/TINY build (kthesaurus)

HTH

Will

Details: 
1) As you can see some action icons are not their advertised size which is not 
really a problem, however others are larger and will be downscaled at runtime.
RPMLINT report:
===============
calligra.i586: W: zero-length /usr/share/icons/oxygen/scalable/actions/shape-
choose.svgz
calligra-tools.i586: W: wrong-icon-size 
/usr/share/icons/hicolor/48x48/hildon/SpreadSheet.png expected: 48x48 ac
tual: 128x128
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/32x32/actions/view-sort-ascending.p
ng expected: 32x32 actual: 22x22
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/aotop.png expected: 2
2x22 actual: 19x19
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/aoleft.png expected: 
22x22 actual: 19x19
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/kotext-character.png 
expected: 22x22 actual: 16x16
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/char.png expected: 22
x22 actual: 16x16
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/aoright.png expected:
 22x22 actual: 19x19
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/16x16/actions/inline_table.png expe
cted: 16x16 actual: 19x18
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/kotext-paragraph.png 
expected: 22x22 actual: 16x16
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/zoom-two-pages.png ex
pected: 22x22 actual: 22x18
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/16x16/actions/inline_image.png expe
cted: 16x16 actual: 19x18
calligra.i586: W: wrong-icon-size 
/usr/share/kde4/apps/koffice/icons/hicolor/22x22/actions/aobottom.png expected
: 22x22 actual: 19x19
calligra-stage.i586: W: wrong-icon-size 
/usr/share/icons/hicolor/16x16/actions/black.png expected: 16x16 actual:
 32x32
calligra-stage.i586: W: wrong-icon-size 
/usr/share/icons/hicolor/16x16/actions/highlight.png expected: 16x16 act
ual: 48x48
calligra-stage.i586: W: wrong-icon-size 
/usr/share/icons/hicolor/16x16/actions/pen.png expected: 16x16 actual: 4
8x48
Your icon file is installed in a fixed-size directory, but has a largely
incorrect size. Some desktop environments (e.g. GNOME) display them wrongly

2) calligra-tools.i586: W: non-executable-script 
/usr/share/applications/kde4/okularApplication_odp.desktop 0644L /usr/bin/env
The .desktop file is prefixed with a shebang - is this some hack for Hildon 
not knowing how to launch a desktop file?

3) Please fix the install location 

4) From the specfile, we see that parts of kthesaurus are only installed in 
the non tiny (desktop) build - is this correct?
"
%files kthesaurus
...
%if %desktop
%_kde4_modules/thesaurustool.so
%_kde_share_dir/services/thesaurustool.desktop
%_kde4_appsdir/koffice/thesaurus
%endif
/usr/bin/kthesaurus
%_libdir/libkdeinit4_kthesaurus.so
%_kde4_applicationsdir/KThesaurus.desktop
%_kde4_iconsdir/hicolor/*/apps/kthesaurus.*
"