Review Request 121557: Added new MediaItem and MediaUri classes

[Stefan Burnicki]

> On Dec. 19, 2014, 6:43 p.m., Andrew Lake wrote:
> > Awesome. Good start for the new MediaItem class. I imagine we'll add setters and getters for all the properties in time.
> > 
> > Thumbs up from me!

I guess most properties will be added to subclasses and leave this class with the most basic information all kind of Media has


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121557/#review72314
-----------------------------------------------------------


On Dec. 19, 2014, 6:49 a.m., Stefan Burnicki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121557/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 6:49 a.m.)
> 
> 
> Review request for Bangarang.
> 
> 
> Repository: bangarang
> 
> 
> Description
> -------
> 
> - Introduced new MediaItem and MediaUri classes
> - Renamed old MediaItem to OldMediaItem to separate old architecture from new
>   In the long run all references to OldMediaItem should become extinct
> - Added architecture overview graphic
>   (The graphic is created with the application yEd and can be edited with it)
> 
> 
> Diffs
> -----
> 
>   .gitignore 567609b1234a9b8806c5a05da6c866e480aa148d 
>   doc/architecture.graphml PRE-CREATION 
>   doc/architecture.png PRE-CREATION 
>   src/CMakeLists.txt cbae7be5e9087a8b1e07f26e4d704ebe8d0937df 
>   src/platform/listengines/cachelistengine.h 2b22838a2c274e866d99d5dfe36692f71bb68eee 
>   src/platform/listengines/cachelistengine.cpp a23d32f58c8900e22ddfaca3b3065e8037a16928 
>   src/platform/listengines/filelistengine.h 957177b4d9c759bac09e2a4031a58497c391bca6 
>   src/platform/listengines/medialistsengine.cpp 32740ccf3261c8c36d5cb99d2bea2438e7e91842 
>   src/platform/listengines/savedlistsengine.h fe24f41a2e175d145aa16d4877ac772d2f19446e 
>   src/platform/listengines/savedlistsengine.cpp 5d9db17faa3d8e47280b17e57cd91527005091f2 
>   src/platform/mediaitem.h PRE-CREATION 
>   src/platform/mediaitem.cpp PRE-CREATION 
>   src/platform/mediaitemmodel.h cd6d073ab11707e2eb89f08fcc2aee1abe4a0a02 
>   src/platform/mediaitemmodel.cpp a6b495ee9d3432ad9686af1d648f0de6401ec8b0 
>   src/platform/medialistcache.h fcc0337f37a68e243f43cd627eefa107dfbb87d5 
>   src/platform/medialistcache.cpp f8a045f6d0dd214bc832789c3cf55f965ecc69d1 
>   src/platform/mediauri.h PRE-CREATION 
>   src/platform/mediauri.cpp PRE-CREATION 
>   src/platform/utilities/artwork.h 6af7d20cb1c9d6a2b083fee5dfba5958aed0fbe2 
>   src/platform/utilities/artwork.cpp 635c23e427af32c96d78269ebd9a13d87af2bbd3 
>   src/platform/utilities/filetags.h 3cd94ce09425686e0f54d5cca5e87bcef8ab5414 
>   src/platform/utilities/filetags.cpp 6f4b904f62cd625c03001d7e35e3b004b0521bec 
>   src/platform/utilities/mediaitems.h 3c6c313151093b32f9aac9562c61c0dc3e1d7b2f 
>   src/platform/utilities/mediaitems.cpp 3ddec35389c09d0fae660ef154c9be48f4f169b5 
>   src/platform/utilities/thread.h 7cb4cb608314f9415dba61ac6d32df4d943f3af6 
>   src/platform/utilities/thread.cpp 5d56674a6e39ee5d3b44396baabb95550c471bd9 
>   src/platform/utilities/typechecks.cpp 24e0b9a20b26e59c0dd4611ba09bd7617aa8c874 
>   src/platform/listengines/filelistengine.cpp fa3f2b3f7cecc9bad1c4108f43932214791f898e 
>   src/platform/listengines/listengine.h 562d3e1514c3e72e171b5aa2125f72d6ba89c525 
>   src/platform/listengines/listengine.cpp 5c35f412160e4cdcb39a7a56e207262b7a580059 
>   src/platform/listengines/medialistsengine.h e47345c5769b66e205fa173945a93d3f768a96bc 
> 
> Diff: https://git.reviewboard.kde.org/r/121557/diff/
> 
> 
> Testing
> -------
> 
> Not yet, but it compiles. We should add unit tests soon.
> 
> 
> Thanks,
> 
> Stefan Burnicki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/bangarang/attachments/20141222/c5ac9fe0/attachment.html>