<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121557/">https://git.reviewboard.kde.org/r/121557/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 19th, 2014, 6:43 p.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Awesome. Good start for the new MediaItem class. I imagine we'll add setters and getters for all the properties in time.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thumbs up from me!</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess most properties will be added to subclasses and leave this class with the most basic information all kind of Media has</p></pre>
<br />
<p>- Stefan</p>
<br />
<p>On December 19th, 2014, 6:49 a.m. UTC, Stefan Burnicki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Bangarang.</div>
<div>By Stefan Burnicki.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2014, 6:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bangarang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Introduced new MediaItem and MediaUri classes</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Renamed old MediaItem to OldMediaItem to separate old architecture from new
In the long run all references to OldMediaItem should become extinct</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added architecture overview graphic
(The graphic is created with the application yEd and can be edited with it)</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not yet, but it compiles. We should add unit tests soon.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(567609b1234a9b8806c5a05da6c866e480aa148d)</span></li>
<li>doc/architecture.graphml <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/architecture.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(cbae7be5e9087a8b1e07f26e4d704ebe8d0937df)</span></li>
<li>src/platform/listengines/cachelistengine.h <span style="color: grey">(2b22838a2c274e866d99d5dfe36692f71bb68eee)</span></li>
<li>src/platform/listengines/cachelistengine.cpp <span style="color: grey">(a23d32f58c8900e22ddfaca3b3065e8037a16928)</span></li>
<li>src/platform/listengines/filelistengine.h <span style="color: grey">(957177b4d9c759bac09e2a4031a58497c391bca6)</span></li>
<li>src/platform/listengines/medialistsengine.cpp <span style="color: grey">(32740ccf3261c8c36d5cb99d2bea2438e7e91842)</span></li>
<li>src/platform/listengines/savedlistsengine.h <span style="color: grey">(fe24f41a2e175d145aa16d4877ac772d2f19446e)</span></li>
<li>src/platform/listengines/savedlistsengine.cpp <span style="color: grey">(5d9db17faa3d8e47280b17e57cd91527005091f2)</span></li>
<li>src/platform/mediaitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/mediaitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/mediaitemmodel.h <span style="color: grey">(cd6d073ab11707e2eb89f08fcc2aee1abe4a0a02)</span></li>
<li>src/platform/mediaitemmodel.cpp <span style="color: grey">(a6b495ee9d3432ad9686af1d648f0de6401ec8b0)</span></li>
<li>src/platform/medialistcache.h <span style="color: grey">(fcc0337f37a68e243f43cd627eefa107dfbb87d5)</span></li>
<li>src/platform/medialistcache.cpp <span style="color: grey">(f8a045f6d0dd214bc832789c3cf55f965ecc69d1)</span></li>
<li>src/platform/mediauri.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/mediauri.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platform/utilities/artwork.h <span style="color: grey">(6af7d20cb1c9d6a2b083fee5dfba5958aed0fbe2)</span></li>
<li>src/platform/utilities/artwork.cpp <span style="color: grey">(635c23e427af32c96d78269ebd9a13d87af2bbd3)</span></li>
<li>src/platform/utilities/filetags.h <span style="color: grey">(3cd94ce09425686e0f54d5cca5e87bcef8ab5414)</span></li>
<li>src/platform/utilities/filetags.cpp <span style="color: grey">(6f4b904f62cd625c03001d7e35e3b004b0521bec)</span></li>
<li>src/platform/utilities/mediaitems.h <span style="color: grey">(3c6c313151093b32f9aac9562c61c0dc3e1d7b2f)</span></li>
<li>src/platform/utilities/mediaitems.cpp <span style="color: grey">(3ddec35389c09d0fae660ef154c9be48f4f169b5)</span></li>
<li>src/platform/utilities/thread.h <span style="color: grey">(7cb4cb608314f9415dba61ac6d32df4d943f3af6)</span></li>
<li>src/platform/utilities/thread.cpp <span style="color: grey">(5d56674a6e39ee5d3b44396baabb95550c471bd9)</span></li>
<li>src/platform/utilities/typechecks.cpp <span style="color: grey">(24e0b9a20b26e59c0dd4611ba09bd7617aa8c874)</span></li>
<li>src/platform/listengines/filelistengine.cpp <span style="color: grey">(fa3f2b3f7cecc9bad1c4108f43932214791f898e)</span></li>
<li>src/platform/listengines/listengine.h <span style="color: grey">(562d3e1514c3e72e171b5aa2125f72d6ba89c525)</span></li>
<li>src/platform/listengines/listengine.cpp <span style="color: grey">(5c35f412160e4cdcb39a7a56e207262b7a580059)</span></li>
<li>src/platform/listengines/medialistsengine.h <span style="color: grey">(e47345c5769b66e205fa173945a93d3f768a96bc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121557/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>