Amarok 1.4 collection and artwork importing

[Jeff Mitchell]

Pedro de Carvalho Gomes wrote:
> One way to do this it to import the [Collection Folders] section from
> A1's ~/.kde/share/config/amarokrc.

It would be a nice thing to add the ability to the importer to import
the collection folders from a given 1.4 amarokrc. Note that you can't
rely on ~/.kde vs. ~/.kde4 as it's distribution-dependent, so you'd need
to have the user specify the location of their 1.4 amarokrc. (Although
this won't achieve your original objective, it will at least make it
nicer for the 1.4->2.2 user to get started.)

If you do this, take a look at what the code from the settings dialog
does when you select directories, and imitate that behavior.

> But I agree that it would take some
> work. I wasn't suggesting you to implement it. All I've asked was what
> would the be the consequences. Thank you for the opinion, I'll sure
> take into account when I decide if I am going to implement it or not.

Please keep in mind what I've said before: that if you attempt to modify
the import behavior to remove the need for scanning the files, your
patch is likely to be rejected. There are other things that go on during
scanning besides just populating the database, and most of these have
changed their behavior in A2, and need a rescan to get things sane
again. Things like compilation/various artists detection, file tracking
updates, and so on.

It's not really a worthwhile goal, especially since rescanning is
something that will have to be done periodically anyways (for instance,
the upcoming 2.2.1 will require a full rescan upon first startup). It's
not that we want to force the user to do full rescans over and over, but
sometimes it's necessary -- for instance, when the db schema changes in
a major way. If we sometimes find it necessary to force full rescans on
even minor updates, I don't see why anyone should have a serious problem
with it when there is a major update.

Better to just change the text to not claim to import tracks, fix the
importer to not try to (incorrectly) import tracks, and be done with it.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/amarok/attachments/20091029/f72ad4da/attachment.sig>