Amarok 1.4 collection and artwork importing

Jeff Mitchell mitchell at kde.org
Thu Oct 29 14:20:25 UTC 2009


Pedro de Carvalho Gomes wrote:
> Thanks Guðlaugur.
> 
> This "Import Collection" name is just one of my points. The name
> mislead me to think that it should import my entire collection. And
> the second point is that it indeed imports my A1 collection partially
> . I've shown how this happens on my last e-mail.
> 
> Anyway, I still believe that maybe "Import Collection" can be used to
> import the entire collection.


It's nice that you continue to believe that. But despite your totally
unfounded belief, you're factually wrong. The "partial" imports are
likely due to the importer doing things it shouldn't, which is
populating data with only partial consistency, and the importer should
be fixed to ignore those things. The reason you see partial collections
is because the collection browser is getting bad and inconsistent data
back from queries, not because you're only getting part of the
collection imported and it's magically skipping some tracks.

I honestly don't understand why you won't listen to the actual facts
being told to you by the main Amarok developer working on the SQL
collection -- specifically the scanning and database schema and
insertion parts of it.

> I've understood that all files should be
> rescaned, but I think that the valid Urls returned from the SQL query
> could be used as the input of the rescan, as an alternative to the
> directories chosen at the "Collection Folders" treeview. This way the
> import Tool would mark the collection folders. Again, If someone has a
> constructive opinion about this, I would really appreciate.

You want to be constructive? Fix the importer to not import partial and
unusable fragments of data, i.e. fix it to only import statistics, and
update the dialog that shows when you press Import Collection to not
suggest that it will import track information. Then send a merge request.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/amarok/attachments/20091029/a180c591/attachment.sig>


More information about the Amarok mailing list