[Bug fixes] MP4 tags

[Jeff Mitchell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Kretschmann wrote:
> 2009/3/17 Valentin Rouet <v.rouet at gmail.com>:
>> This patch fixes 2 problems with mp4 files tags :
>> 1) Amarok crashed when you tried to open a mp4 file that had an empty
>> "composer" or "disk" tag
>> 2) The collection scanner crashed while analysing the same kind of files
>>
>> Here's the diff so you can review it.
> 
> Thanks, I've committed the patch, after cleaning it up a bit. There
> were two small issues with it:
> 
> 1) "QString foo = QString("");" is equivalent with just "QString
> foo;", and the latter is preferred.
> 
> 2) Spaces, not tabs.
> 
> 
> Also, I couldn't really test the functionality itself, as I don't have
> MP4 files. If anyone here got such files, please test it :)

Yep, I'm in the same boat, which is why I (stupidly) didn't catch this
myself when I was coding in the support :-)  (previously it was handled
in libmp4v2, but it's in taglib now but in a different fashion).

Sorry for the crashes, thanks for the patches.

- --Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iEYEARECAAYFAknABKcACgkQANYdqNCuGCVsVACePhnW1u4OtHvPuHn70mAlslXr
cFIAn2pIZYh7NmjZo3bAEmDbBiPxGlQN
=UG5k
-----END PGP SIGNATURE-----