[Bug fixes] MP4 tags

Mark Kretschmann kretschmann at kde.org
Tue Mar 17 18:37:32 UTC 2009


2009/3/17 Valentin Rouet <v.rouet at gmail.com>:
> This patch fixes 2 problems with mp4 files tags :
> 1) Amarok crashed when you tried to open a mp4 file that had an empty
> "composer" or "disk" tag
> 2) The collection scanner crashed while analysing the same kind of files
>
> Here's the diff so you can review it.

Thanks, I've committed the patch, after cleaning it up a bit. There
were two small issues with it:

1) "QString foo = QString("");" is equivalent with just "QString
foo;", and the latter is preferred.

2) Spaces, not tabs.


Also, I couldn't really test the functionality itself, as I don't have
MP4 files. If anyone here got such files, please test it :)

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org



More information about the Amarok mailing list