little cleanup/patch regarding iPod handling in cmake

Maciej Mrozowski reavertm at wp.pl
Wed Jun 24 12:58:46 UTC 2009


On Wednesday 24 of June 2009 08:31:26 Eelko Berkenpies wrote:
> On Tue, 23 Jun 2009 17:52:30 -0700, Alejandro Wainzinger
>
> <aikawarazuni at gmail.com> wrote:
> > Committed.  Thanks for the patch.
>
> Is it correct that *something* became required by this patch (except for
> liblastfm, obviously)?
>
> CMake fails for me: http://fpaste.org/paste/16289
>
> I am using SVN revision 986077.

Problem is with macro_ensure_version, which doesn't accept empty version 
specifier (and it's empty when find_package is not able to find Ipod library).

Fixed patch adds if (IPOD_FOUND) guard for macro_ensure_version.
All IPOD_0_7 occurrences are also removed from cmake as there's no need for 
additional variable only to check whether >=0.7 version is available as older 
versions are not accepted anyway (see 
src/collection/ipodcollection/CMakeLists.txt).

-- 
regards
MM

-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-ipod-cmake.patch
Type: text/x-patch
Size: 3885 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090624/7259feed/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090624/7259feed/attachment.sig>


More information about the Amarok mailing list