Playlist Additions When Filtering (Proposed Patch)

[Nikolaj Hald Nielsen]

Hi John

Thanks for the patch.

The attached patch was originally intended to address a usability pet peeve
> of mine, written up by someone else in bug #200709<https://bugs.kde.org/show_bug.cgi?id=200709>.
> Quick description: When replacing a playlist and using the search filter, it
> could be confusing when the playlist appeared blank (as no entries matched
> the filter).
>
> The simple fix is to clear the filter before replacing the playlist.


This makes a lot of sense and I agree that clearing the playlist when using
the "replace" action is a really good idea!

However, further inspection of the bug tracker gives
bug#193527<https://bugs.kde.org/show_bug.cgi?id=193527>,
> where the filter is apparently also applied to anything added to the
> playlist. This can be fixed in a similar way by clearing the filter before
> any addition to the playlist. This is what the patch implements.


As far as I can tell, these 2 issues are only conceptually related and not
related code wise. This bug has to do with the filter in the browsers and
what tracks are actually getting added to the playlist, not which one the
playlist actually chooses to show. Also, in my opinion, I think this is
actually the correct behavior. Of course, this is up for discussion.


> Hopefully this is a solution to the problem but I thought I would mail
> because I have concerns that:
> 1.) Because this uses signals and slots between two widgets (filter and
> playlist), it may introduce some sort of race condition I'm not aware of.


I don't see any issues with it.

2.) A developer has a grand scheme for these things and this is going to be
> cleverly redesigned anyway.


No, I don't think there are any grand plans regarding this particular little
fix! :-)


The one issue I do have with your current patch is that it clears the filter
on all inserts, not just when replacing the entire playlist. I have been
thinking about this for a while, and I think it makes sense to keept he
filter when working on an existing playlist and only clearing it when doing
a "replace". So if you can redo the patch to only clear the playlist filter
in this particular case, I will be happy to commit it! :-)

- Nikolaj
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090730/be43cac7/attachment.html>