Playlist Additions When Filtering (Proposed Patch)

[John Atkinson]

Hi all,

The attached patch was originally intended to address a usability pet peeve
of mine, written up by someone else in bug
#200709<https://bugs.kde.org/show_bug.cgi?id=200709>.
Quick description: When replacing a playlist and using the search filter, it
could be confusing when the playlist appeared blank (as no entries matched
the filter).

The simple fix is to clear the filter before replacing the playlist.

However, further inspection of the bug tracker gives
bug#193527<https://bugs.kde.org/show_bug.cgi?id=193527>,
where the filter is apparently also applied to anything added to the
playlist. This can be fixed in a similar way by clearing the filter before
any addition to the playlist. This is what the patch implements.

Hopefully this is a solution to the problem but I thought I would mail
because I have concerns that:
1.) Because this uses signals and slots between two widgets (filter and
playlist), it may introduce some sort of race condition I'm not aware of.
or
2.) A developer has a grand scheme for these things and this is going to be
cleverly redesigned anyway.


Thanks,
John ( First Amarok patch, be nice ;) )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090730/59de8e7a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-bug200709.diff
Type: text/x-patch
Size: 1568 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090730/59de8e7a/attachment.diff>