[Patch] "No grouping" checkbox in playlist layout

[Tim Bocek]

I'm willing to give it a try, though I might be a bit short on time in the
next few days and might not get it by string freeze, which IIRC is tomorrow
(if I gathered correctly from the database junior job thread, I can't find a
page on the InfoBase wiki that has this).

Just to clarify: on the UI side, you're asking me to remove the "No
Grouping" checkbox and replace it with a "Group By" combo box that has:
Artist
Album
Composer
etc.
No Grouping

If so, some questions:  Does the menu at the bottom of the playlist window
that already has these options stay, or do we remove it in favor of the
combo box in the layout (I would vote to keep it, personally).  If yes to
that, if the user selects a playlist that is set up to group by, say,
composer, and then selects in the widget in the playlist window to group by
artist instead, does that change the playlist layout or just override the
default?

No worries about the sorting slip, I know what you meant ;)

Thanks
-Tim

On Sun, Aug 30, 2009 at 3:19 AM, Nikolaj Hald Nielsen <
nhnfreespirit at gmail.com> wrote:

> So...
>
> I committed your patch and it works great. however, it started a bit
> of a discussion among the regular Amarok devs about whether grouping
> really should be integrated into the playlist layouts instead of
> something completely separate. So if you are up for it, I have an idea
> of how you can expand on the patch you already did simply the user
> experience even more, and likely deal with the remaining issues of
> your patch (the inline editing stuff) as a side effect.
>
> The idea is that instead of your new checkbox, we would actually have
> a drop down list for selecting the grouping mode to use for each
> layout. One of these options would be "no grouping" which would work
> much like your checkbox does now (disabling editing of header and body
> items). This makes sense, as a grouping mode is really mostly
> worthless unless there is a playlist layout that matches. (for
> instance, it makes little sense to use a layout that shows album info
> in the header if you are grouping by composer... )
>
> However, instead of having the rendering code use the single items
> layout config for both body and single tracks, you would integrate it
> with the sorting proxy so that if the sorting mode is set to "no
> sorting" it will simply return the "single" group status for each and
> every track, meaning that they will all get painted using the "single"
> layout config anyway. This would remove some of the code you have
> added to the delegate and make sure that you don't have to special
> case anything for the inline editor either.
>
> I think this would really tie everything together in a very nice way
> and simplify the code a bit as well. If you are interested in this,
> let me know. If not We will likely try to do it ourselves asap as we
> have a freeze coming up soon. You can go to irc channel #amarok on
> irc.freenode.net and poke either me (nhn) or Teo (Teo`) for help, or
> you can of course ask questions here.
>
> - Nikolaj
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090830/4f94edeb/attachment.html>