Junior Job - external MySQL config

[Leo Franchi]

On Saturday 29 August 2009 13:49:06 John Atkinson wrote:
> Hey Lydia, Jeff, others,
>
> I assume from the lack of emails that this still needs added.
>
> Attached should be a patch to add a database configuration dialog with
> similar functionality to the one in 1.4. As Jeff suggested, it also
> includes some help for setting user access permissions in MySQL. An icon is
> still required ("preferences-database-amarok"), but the rest should be all
> there.
>
> Screenshots attached for the curious who don't want to have to apply the
> patch just to take a look. The current git HEAD contains a new equaliser
> has made the config screen much wider than before. I'm not sure if this is
> permanent so I've provided captures of both.

Took a quick look at the screenshots--looks really good. Regarding the width 
of the config dialog, we're going to be making it smaller (mark just made a 
commit to that effect). 

If no one else has taken a look by tonight i'll check it out and apply it if 
it's OK. Please take a look at our HACKING/intro_and_style.txt for the style 
that we use (for example, spaces between ( foo ), I noticed some lines are 
missing them).

cheers,
leo



> I should have time for fixes and polish before string freeze time if you
> have comments.
>
> Thanks,
> John
>
>
>
> 2009/8/25 Jeff Mitchell <mitchell at kde.org>
>
> > John Atkinson wrote:
> > > Hey All,
> > >
> > > I'd also be happy to do this if Kolja cannot. I am unlikely to have any
> > > free time before Friday anyway.
> > >
> > > Would I be correct in assuming that we're only concerned with the GUI
> > > here and that all that needs to be done is load/save the values via an
> > > existing class? (which already handles storing the configuration data)
> >
> > Yes. The values are stored in the amarokrc file (there are easy ways to
> > get and set it).
> >
> > The hard part will be coming up with a design that keeps it easy/doesn't
> > overwhelm people using the default embedded collection but doesn't make
> > it so complicated to access that people wanting the server setup can't
> > find it. Bonus points if it also displays enough text on there for them
> > to get it set up without having to go to our website (just needs room
> > for a short message explaining that they first have to run a "GRANT ALL
> > ON ........ " command on MySQL).
> >
> > --Jeff
> >
> >
> > _______________________________________________
> > Amarok mailing list
> > Amarok at kde.org
> > https://mail.kde.org/mailman/listinfo/amarok