Bug 189898 fix

Nikolaj Hald Nielsen nhnfreespirit at gmail.com
Sun Aug 2 15:25:29 UTC 2009


The patch is created the right way, so good work on that! Feel free to call
it something other than my_patch though, that was just meant as an example.
As a rule of thumb, call it something that concisely describes what it does
like "fix_playing_tracks_with_spaces_in_path.diff"

Jeff is right about the "" comparison though. Could you do a new version
that uses QString::isEmpty() please? (look here:
http://doc.qtsoftware.com/4.5/qstring.html)

- Nikolaj
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090802/edec283b/attachment.html>


More information about the Amarok mailing list