Possible to add non-media files to the playlist

[Seb Ruiz]

2008/8/26 Andreas Mützel <andreas.muetzel at gmx.net>:
> Hi,
> I just noticed that you actually can add _any_ type of file (even .txt etc.)
> to the playlist via "Amarok"->"Play media...". Is this really desired?
> I think it would be better to check if the added files can be played before
> adding them to the playlist, wouldn't it?
> As with my last suggestion: Patch attached ;-)
> The patch uses EngineController::canDecode in CollectionManager::trackForUrl
> so that it only returns the track if it can actually be played.
> This has one main disadvantage: if the backend for example can't play
> mp3-files, these files probably couldn't even be added to a playlist. (I'm
> sorry I can't verify this, I don't have any sound-files on my PC that can't
> be played by phonon...)

This isn't a problem as EngineController::canDecode() handles the mp3
case explicitly.

> Do you think this behaviour is desireable?

Yes, this is much better imo. Thanks for the patch.

-- 
Seb Ruiz

http://www.sebruiz.net/