[Fwd: Re: branches/stable/extragear/multimedia/amarok/src]

[hydrogen at notyetimplemented.com]

reply-to--;
---------------------------- Original Message ----------------------------
Subject: Re: branches/stable/extragear/multimedia/amarok/src
From:    hydrogen at notyetimplemented.com
Date:    Wed, March 7, 2007 6:47 am
To:      kde-commits at kde.org
Cc:      ovy at alum.mit.edu
--------------------------------------------------------------------------

Hello,

> SVN commit 640156 by ovy:
>
> Speed up Playlist::saveXML by about 40% by writing to the stream directly
> and
> careful buffering. The method is critical, as it runs every time the
> playlist is changed,
> so improvements here affect overall responsiveness. In my build ~5100
> items saves in
> ~2.2s instead of ~3.6s
>
>
>  M  +60 -21    metabundle.cpp
>  M  +17 -7     playlist.cpp
>
>
[snip]
> +        else if ( uc == '<' )  stream << "<";
> +        else if ( uc == '>' )  stream << ">";
> +        else if ( uc == '&' )   stream << """;
> +        else if ( uc == '"')    stream << "&";

These last two lines look backwards to me?
[snip]