speed improvements (patch)

[Mark Kretschmann]

On Thursday 05 October 2006 07:30, Ovidiu Gheorghioiu wrote:
> I've attached a patch (including also the unittest that crashed it
> before, 100% on my dual-core) that makes it work well in multiple
> threads. It's not optimal, in that the single global lock, which is
> also held over refs / derefs, might some day become a performance
> problem (I've verified that right now it isn't) but at least it's
> safe. And while QString is also unsafe, at least it's only unsafe when
> an instance is explicitly used between threads, but AtomicString was
> unsafe even on unrelated instances, like in my unit test, that just
> happen to use the same text.

Great work! I do have one nitpick though: The inconsistent formatting. You're 
mixing tabs and spaces and different styles of indentantion. Here at Amarok 
we are a bit anal about formatting.

Could you please refer to the HACKING document in the Amarok source tree and 
reformat your patch?

-- 
Mark