extragear/multimedia/amarok/src/mediadevice/ipod

[Seb Ruiz]

On 08/11/06, Martin Aumueller <aumuell at reserv.at> wrote:
> I don't think that we should add processEvents() here: this makes it more
> likely that some user actions interfere with the ipod's state. And as the
> scanning for orphans is a) an infrequent operation which b) has to be
> explicitly triggered by the user, I think that it is not an issue if the ui
> is blocked for some time.

Okay, understandable. My database got corrupted somehow, and all songs
were listed under videos. It's happened before, and i don't know how
so i just removed the database and started again. I have a backup of
the database if you'd like to see it.

> I also think that this debug output should remain enabled, as this makes it
> easier to diagnose possible problems w/o users needing to change program
> code. And when this message is printed, there is already a problem with the
> user's ipod, so we definitely need some help in diagnosing it.

I spent more than 5 minutes waiting on the operation to occur, which
is so long. Granted, i am on my laptop which only has USB 1.1.

Do you need me to re-enable the debug?


>
> On Tue November 7 2006 23:40, Seb Ruiz wrote:
> > SVN commit 603135 by seb:
> >
> > Don't show debug when scanning for orphaned files. rescanning over 4000
> > tracks takes a while and blocks the ui. maybe we need processEvents() here.
> >
> >
> >  M  +1 -1      ipodmediadevice.cpp
> >
> >
> > ---
> > trunk/extragear/multimedia/amarok/src/mediadevice/ipod/ipodmediadevice.cpp
> > #603134:603135 @@ -1206,7 +1206,7 @@
> >              Itdb_Track *track = m_files[ipodPath.lower()];
> >              if(!track)
> >              {
> > -                debug() << "file: " << filename << " is orphaned" << endl;
> > +                // debug() << "file: " << filename << " is orphaned" <<
> > endl; IpodMediaItem *item = new IpodMediaItem(m_orphanedItem, this);
> > item->setType(MediaItem::ORPHANED);
> >                  KURL url = KURL::fromPathOrURL(filename);
>


-- 
http://www.sebruiz.net/