use mtp or usm for an iRiver T10?

[Andreas Pakulat]

On 02.11.06 19:05:16, Andreas Pakulat wrote:
> I'm currently having a problem with amaroks "sync with media player"
> feature, it offeres to change spaces to underscores and also allows to
> replace non-ascii text by underscores. But it doesn't have an option to
> replace all characters that don't work on FAT filesystems to
> underscores. This includes "*,%()" and possibly some others. Also I
> think the length of directory and filenames is limited on FAT.

This was actually easier for the beginning, because I currently cannot
reboot to reflash the player..

I do have a KDE svn account and could commit a change to app.cpp,
changing vfatPath to also replace some more characters. I'm not doing it
because nobody here knows me and I don't want to get flame-mails about
changing amarok without anybody commenting.

Thus I attach the patch to this mail for review, basically I took all
characters that are on my keyboard and are not letters/numbers/ /./-/_
and replace them also with an underscore.

Comments welcome.

Andreas

-- 
Be cautious in your daily affairs.
-------------- next part --------------
Index: app.cpp
===================================================================
--- app.cpp	(Revision 601268)
+++ app.cpp	(Arbeitskopie)
@@ -1326,7 +1326,12 @@ namespace Amarok
             if( c < QChar(0x20)
                     || c=='*' || c=='?' || c=='<' || c=='>'
                     || c=='|' || c=='"' || c==':' || c=='/'
-                    || c=='\\' )
+                    || c=='\\' || c=='%' || c=='(' || c==')'
+		    || c=='[' || c==']' || c=='{' || c=='}'
+		    || c=='+' || c=='+' || c=='=' || c=='|'
+		    || c=='#' || c=='$' || c=='^' || c=='&'
+		    || c=='@' || c=='!' || c=='`' || c=='~'
+		    || c=='\'' || c==';' || c==',' )
                 c = '_';
             s.ref( i ) = c;
         }