extragear/multimedia/amarok/src

[Andrew Turner]

Well, the previous behaviour was inconsistent - if you didn't have any
other songs except compilations for a certain artist then that artist
wouldn't show up at all in a list of artists, and yet for artists that
did appear, you would be able to see their compilation songs both
under their name and Various Artists.

As for your question, yes, compilation songs will only show up under
Various Artists, no matter what the Group By.

I have just realised as I typed this reply that there's an obvious
regression I've just introduced if you don't have Artists at the top
of the tree (without a Various Artists catagory, compilations aren't
shown).

So, anyone care to comment on what they think would be the best way?

Andrew

On 16/06/06, Martin Aumueller <aumueller at uni-koeln.de> wrote:
> Hm, I don't think that the old behaviour was a bug: it is useful to see what
> songs you have by an artist - and that is the full list of songs, including
> those on a compilation. The only thing that could be a little bit confusing
> is that some songs are listed twice in the collection browser.
>
> BTW, what does happen if you are sorting by Artist only: are all the songs on
> all the compilations in your collection appearing below Various Artists
> instead below the artist?
>
> On Fri June 16 2006 19:44, Andrew Turner wrote:
> > SVN commit 552135 by aturner:
> >
> > Don't list compilations under the name of the artist - they should only be
> > in Various Artists.
> >
> >
> >  M  +3 -0      collectionbrowser.cpp
> >
> >
> > --- trunk/extragear/multimedia/amarok/src/collectionbrowser.cpp
> > #552134:552135 @@ -919,6 +919,7 @@
> >              isUnknown = tmptext.isEmpty();
> >              if ( !static_cast<CollectionItem*>( item )->isSampler() )
> >              {
> > +             qb.setOptions( QueryBuilder::optNoCompilations );
> >                  if( VisYearAlbum == 1 )
> >                  {
> >                      tmptext = item->text( 0 );
> > @@ -976,6 +977,7 @@
> >
> >              if( !static_cast<CollectionItem*>( item->parent()
> > )->isSampler() ) {
> > +             qb.setOptions( QueryBuilder::optNoCompilations );
> >                  if( VisYearAlbum == 1 )
> >                  {
> >                      tmptext = item->parent()->text( 0 );
> > @@ -1048,6 +1050,7 @@
> >
> >              if ( !static_cast<CollectionItem*>( item->parent()->parent()
> > )->isSampler() ) {
> > +             qb.setOptions( QueryBuilder::optNoCompilations );
> >                  if (VisYearAlbum==1)
> >                  {
> >                      tmptext = item->parent()->parent()->text( 0 );
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>