extragear/multimedia/amarok/src (silent)

[Seb Ruiz]

Jeff - you should read the code :-)

if( ... )
{
   <snip>
   PlaylistItem *item = new PlaylistItem( *it, m_markerListViewItem, false );
}

item isn't doing very much at all.

seb

Quoting Jeff Mitchell <kde-dev at emailgoeshere.com>:

> Why did you do this?
>
> If a file has been added to the playlist, either from the saved one or from
> the collection browser that doesn't exist at the moment it's likely because
> someone moved the file while Amarok was closed / after the previous
> incremental scan and before the next.  If they're using ATF the new location
> will be picked up at the next incremental scan, and the playlistitem would be
> enabled at that time.  The only time they'd be left with a disabled item is
> if they actually deleted the file or if they moved it out of their collection
> folders (in which case at the next incremental scan it'd be removed from
> their collection anyways).  I think the first case is much more likely than
> the second.
>
> This commit invalidates part of ATF's functionality, which is to allow the
> playlistitems to be enabled as items that previously could not be found have
> been found at their new location.
>
> Please respond, but unless there's a good reason to keep it this way I think
> this should be reverted.
>
> --Jeff
>
> On Friday 14 July 2006 08:54, Alexandre Pereira de Oliveira wrote:
>> SVN commit 562243 by aoliveira:
>>
>> SVN_SILENT warnings--
>>
>>  M  +1 -1      playlistloader.cpp
>>
>>
>> --- trunk/extragear/multimedia/amarok/src/playlistloader.cpp #562242:562243
>> @@ -226,7 +226,7 @@
>>                      continue;
>>
>>                  //ATF on, so add anyways, but disable, we expect to find
>> with an update -                PlaylistItem *item = new PlaylistItem( *it,
>> m_markerListViewItem, false ); +                /*PlaylistItem *item = */
>> new PlaylistItem( *it, m_markerListViewItem, false ); }
>>              else
>>              {
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>



-- 
http://www.sebruiz.net/