[patch] forward null check and then dereference

Seb Ruiz me at sebruiz.net
Fri Dec 1 23:00:12 UTC 2006


On 02/12/06, Erik Hovland <erik at hovland.org> wrote:
> This patch addresses the possibility of dereferencing a pointer that
> might be null.
>
> Annotation included in the patch.

Hi Erik,
Thanks for the work on your patches. A couple of comments however.

 - patches sent to the mailing list are usually lost into the ether,
it is very hard to track them. they are much better attached to bug
reports at bugs.kde.org

 - since these are a lot of sanity checking reports, you might want to
just grab yourself a kde svn account and commit the changes yourself.
Would make it much easier. Join us in the irc channel if you want to
do this, #amarok @ irc.freenode.net

 - when creating patches, please patch against current svn - it avoids
complicated conflicts which we need to resolve manually. Just check
out current trunk, and make your changes to the files. When done, do
"svn diff" to create a diff.

Many thanks for the work!
Seb

-- 
http://www.sebruiz.net/



More information about the Amarok mailing list