D10831: Ported some services to Qt5/KF5

Malte Veerman noreply at phabricator.kde.org
Sun Feb 25 12:49:28 UTC 2018


malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  This patch ports the ampache, magnatune and opmldirectory services. I've laid some groundwork for the other services too, but they still have problems. For example: Jamendo has changed its API, which makes the service useless in its current form or the gpodder service using mygpo-qt, which is still in a qt4 world and therefore makes amarok crash when used. Mp3tunes and lastfm don't work either, but I haven't yet investigated why.

REPOSITORY
  R181 Amarok

BRANCH
  kf5_without_kdelibs4

REVISION DETAIL
  https://phabricator.kde.org/D10831

AFFECTED FILES
  src/CMakeLists.txt
  src/core/podcasts/PodcastImageFetcher.cpp
  src/services/CMakeLists.txt
  src/services/ampache/AddServerDialog.cpp
  src/services/ampache/AddServerDialog.h
  src/services/ampache/AmpacheAccountLogin.cpp
  src/services/ampache/AmpacheAccountLogin.h
  src/services/ampache/AmpacheConfig.cpp
  src/services/ampache/AmpacheConfig.h
  src/services/ampache/AmpacheMeta.h
  src/services/ampache/AmpacheService.cpp
  src/services/ampache/AmpacheService.h
  src/services/ampache/AmpacheServiceCollection.cpp
  src/services/ampache/AmpacheServiceCollection.h
  src/services/ampache/AmpacheServiceQueryMaker.cpp
  src/services/ampache/AmpacheServiceQueryMaker.h
  src/services/ampache/AmpacheSettings.cpp
  src/services/ampache/AmpacheSettings.h
  src/services/ampache/CMakeLists.txt
  src/services/ampache/LastfmInfoParser.cpp
  src/services/ampache/NewServerWidget.ui
  src/services/ampache/amarok_service_ampache.desktop
  src/services/gpodder/CMakeLists.txt
  src/services/gpodder/GpodderConfigWidget.ui
  src/services/gpodder/GpodderPodcastMeta.cpp
  src/services/gpodder/GpodderPodcastMeta.h
  src/services/gpodder/GpodderPodcastRequestHandler.cpp
  src/services/gpodder/GpodderProvider.cpp
  src/services/gpodder/GpodderProvider.h
  src/services/gpodder/GpodderService.cpp
  src/services/gpodder/GpodderService.h
  src/services/gpodder/GpodderServiceConfig.cpp
  src/services/gpodder/GpodderServiceConfig.h
  src/services/gpodder/GpodderServiceModel.cpp
  src/services/gpodder/GpodderServiceSettings.cpp
  src/services/gpodder/GpodderServiceSettings.h
  src/services/gpodder/GpodderTreeItem.cpp
  src/services/gpodder/amarok_service_gpodder.desktop
  src/services/jamendo/CMakeLists.txt
  src/services/jamendo/JamendoDatabaseHandler.cpp
  src/services/jamendo/JamendoInfoParser.cpp
  src/services/jamendo/JamendoMeta.cpp
  src/services/jamendo/JamendoService.cpp
  src/services/jamendo/JamendoXmlParser.cpp
  src/services/jamendo/JamendoXmlParser.h
  src/services/jamendo/amarok_service_jamendo.desktop
  src/services/lastfm/AvatarDownloader.h
  src/services/lastfm/CMakeLists.txt
  src/services/lastfm/LastFmConfigWidget.ui
  src/services/lastfm/LastFmService.cpp
  src/services/lastfm/LastFmService.h
  src/services/lastfm/LastFmServiceCollection.cpp
  src/services/lastfm/LastFmServiceConfig.cpp
  src/services/lastfm/LastFmServiceConfig.h
  src/services/lastfm/LastFmServiceSettings.cpp
  src/services/lastfm/LastFmTreeModel.cpp
  src/services/lastfm/LastFmTreeView.cpp
  src/services/lastfm/LastFmTreeView.h
  src/services/lastfm/LoveTrackAction.cpp
  src/services/lastfm/ScrobblerAdapter.cpp
  src/services/lastfm/SimilarArtistsAction.cpp
  src/services/lastfm/SynchronizationAdapter.cpp
  src/services/lastfm/SynchronizationTrack.cpp
  src/services/lastfm/amarok_lastfm_shared_export.h
  src/services/lastfm/amarok_service_lastfm.desktop
  src/services/lastfm/biases/LastFmBias.cpp
  src/services/lastfm/biases/WeeklyTopBias.cpp
  src/services/lastfm/meta/LastFmMeta.cpp
  src/services/lastfm/meta/LastFmMeta.h
  src/services/lastfm/meta/LastFmMeta_p.h
  src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp
  src/services/lastfm/meta/LastFmMultiPlayableCapability.h
  src/services/magnatune/CMakeLists.txt
  src/services/magnatune/MagnatuneActions.cpp
  src/services/magnatune/MagnatuneAlbumDownloader.cpp
  src/services/magnatune/MagnatuneAlbumDownloader.h
  src/services/magnatune/MagnatuneCollectionLocation.cpp
  src/services/magnatune/MagnatuneConfig.cpp
  src/services/magnatune/MagnatuneConfigWidget.ui
  src/services/magnatune/MagnatuneDatabaseHandler.cpp
  src/services/magnatune/MagnatuneDatabaseWorker.cpp
  src/services/magnatune/MagnatuneDownloadDialog.cpp
  src/services/magnatune/MagnatuneDownloadDialog.h
  src/services/magnatune/MagnatuneDownloadHandler.cpp
  src/services/magnatune/MagnatuneDownloadInfo.cpp
  src/services/magnatune/MagnatuneInfoParser.cpp
  src/services/magnatune/MagnatuneMeta.cpp
  src/services/magnatune/MagnatuneMeta.h
  src/services/magnatune/MagnatuneNeedUpdateWidget.cpp
  src/services/magnatune/MagnatuneRedownloadDialog.cpp
  src/services/magnatune/MagnatuneRedownloadDialog.h
  src/services/magnatune/MagnatuneRedownloadHandler.cpp
  src/services/magnatune/MagnatuneRedownloadHandler.h
  src/services/magnatune/MagnatuneSettingsModule.cpp
  src/services/magnatune/MagnatuneStore.cpp
  src/services/magnatune/MagnatuneStore.h
  src/services/magnatune/MagnatuneUrlRunner.cpp
  src/services/magnatune/MagnatuneXmlParser.cpp
  src/services/magnatune/amarok_service_magnatunestore.desktop
  src/services/mp3tunes/CMakeLists.txt
  src/services/mp3tunes/Mp3tunesConfig.cpp
  src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp
  src/services/mp3tunes/Mp3tunesMeta.cpp
  src/services/mp3tunes/Mp3tunesMeta.h
  src/services/mp3tunes/Mp3tunesService.cpp
  src/services/mp3tunes/Mp3tunesServiceCollection.cpp
  src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp
  src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp
  src/services/mp3tunes/Mp3tunesSettingsModule.cpp
  src/services/mp3tunes/Mp3tunesWorkers.cpp
  src/services/mp3tunes/Mp3tunesWorkers.h
  src/services/mp3tunes/amarok_service_mp3tunes.desktop
  src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp
  src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.h
  src/services/mp3tunes/harmonydaemon/main.cpp
  src/services/opmldirectory/AddOpmlWidget.ui
  src/services/opmldirectory/CMakeLists.txt
  src/services/opmldirectory/OpmlDirectoryInfoParser.cpp
  src/services/opmldirectory/OpmlDirectoryInfoParser.h
  src/services/opmldirectory/OpmlDirectoryMeta.h
  src/services/opmldirectory/OpmlDirectoryModel.cpp
  src/services/opmldirectory/OpmlDirectoryModel.h
  src/services/opmldirectory/OpmlDirectoryService.cpp
  src/services/opmldirectory/OpmlDirectoryService.h
  src/services/opmldirectory/OpmlDirectoryView.cpp
  src/services/opmldirectory/amarok_service_opmldirectory.desktop

To: malteveerman, #amarok
Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20180225/ba9ca584/attachment.html>


More information about the Amarok-devel mailing list