<table><tr><td style="">malteveerman created this revision.<br />malteveerman added a reviewer: Amarok.<br />malteveerman added a project: Amarok.<br />malteveerman requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10831" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch ports the ampache, magnatune and opmldirectory services. I've laid some groundwork for the other services too, but they still have problems. For example: Jamendo has changed its API, which makes the service useless in its current form or the gpodder service using mygpo-qt, which is still in a qt4 world and therefore makes amarok crash when used. Mp3tunes and lastfm don't work either, but I haven't yet investigated why.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>kf5_without_kdelibs4</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10831" rel="noreferrer">https://phabricator.kde.org/D10831</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />

src/core/podcasts/PodcastImageFetcher.cpp<br />

src/services/CMakeLists.txt<br />

src/services/ampache/AddServerDialog.cpp<br />

src/services/ampache/AddServerDialog.h<br />

src/services/ampache/AmpacheAccountLogin.cpp<br />

src/services/ampache/AmpacheAccountLogin.h<br />

src/services/ampache/AmpacheConfig.cpp<br />

src/services/ampache/AmpacheConfig.h<br />

src/services/ampache/AmpacheMeta.h<br />

src/services/ampache/AmpacheService.cpp<br />

src/services/ampache/AmpacheService.h<br />

src/services/ampache/AmpacheServiceCollection.cpp<br />

src/services/ampache/AmpacheServiceCollection.h<br />

src/services/ampache/AmpacheServiceQueryMaker.cpp<br />

src/services/ampache/AmpacheServiceQueryMaker.h<br />

src/services/ampache/AmpacheSettings.cpp<br />

src/services/ampache/AmpacheSettings.h<br />

src/services/ampache/CMakeLists.txt<br />

src/services/ampache/LastfmInfoParser.cpp<br />

src/services/ampache/NewServerWidget.ui<br />

src/services/ampache/amarok_service_ampache.desktop<br />

src/services/gpodder/CMakeLists.txt<br />

src/services/gpodder/GpodderConfigWidget.ui<br />

src/services/gpodder/GpodderPodcastMeta.cpp<br />

src/services/gpodder/GpodderPodcastMeta.h<br />

src/services/gpodder/GpodderPodcastRequestHandler.cpp<br />

src/services/gpodder/GpodderProvider.cpp<br />

src/services/gpodder/GpodderProvider.h<br />

src/services/gpodder/GpodderService.cpp<br />

src/services/gpodder/GpodderService.h<br />

src/services/gpodder/GpodderServiceConfig.cpp<br />

src/services/gpodder/GpodderServiceConfig.h<br />

src/services/gpodder/GpodderServiceModel.cpp<br />

src/services/gpodder/GpodderServiceSettings.cpp<br />

src/services/gpodder/GpodderServiceSettings.h<br />

src/services/gpodder/GpodderTreeItem.cpp<br />

src/services/gpodder/amarok_service_gpodder.desktop<br />

src/services/jamendo/CMakeLists.txt<br />

src/services/jamendo/JamendoDatabaseHandler.cpp<br />

src/services/jamendo/JamendoInfoParser.cpp<br />

src/services/jamendo/JamendoMeta.cpp<br />

src/services/jamendo/JamendoService.cpp<br />

src/services/jamendo/JamendoXmlParser.cpp<br />

src/services/jamendo/JamendoXmlParser.h<br />

src/services/jamendo/amarok_service_jamendo.desktop<br />

src/services/lastfm/AvatarDownloader.h<br />

src/services/lastfm/CMakeLists.txt<br />

src/services/lastfm/LastFmConfigWidget.ui<br />

src/services/lastfm/LastFmService.cpp<br />

src/services/lastfm/LastFmService.h<br />

src/services/lastfm/LastFmServiceCollection.cpp<br />

src/services/lastfm/LastFmServiceConfig.cpp<br />

src/services/lastfm/LastFmServiceConfig.h<br />

src/services/lastfm/LastFmServiceSettings.cpp<br />

src/services/lastfm/LastFmTreeModel.cpp<br />

src/services/lastfm/LastFmTreeView.cpp<br />

src/services/lastfm/LastFmTreeView.h<br />

src/services/lastfm/LoveTrackAction.cpp<br />

src/services/lastfm/ScrobblerAdapter.cpp<br />

src/services/lastfm/SimilarArtistsAction.cpp<br />

src/services/lastfm/SynchronizationAdapter.cpp<br />

src/services/lastfm/SynchronizationTrack.cpp<br />

src/services/lastfm/amarok_lastfm_shared_export.h<br />

src/services/lastfm/amarok_service_lastfm.desktop<br />

src/services/lastfm/biases/LastFmBias.cpp<br />

src/services/lastfm/biases/WeeklyTopBias.cpp<br />

src/services/lastfm/meta/LastFmMeta.cpp<br />

src/services/lastfm/meta/LastFmMeta.h<br />

src/services/lastfm/meta/LastFmMeta_p.h<br />

src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp<br />

src/services/lastfm/meta/LastFmMultiPlayableCapability.h<br />

src/services/magnatune/CMakeLists.txt<br />

src/services/magnatune/MagnatuneActions.cpp<br />

src/services/magnatune/MagnatuneAlbumDownloader.cpp<br />

src/services/magnatune/MagnatuneAlbumDownloader.h<br />

src/services/magnatune/MagnatuneCollectionLocation.cpp<br />

src/services/magnatune/MagnatuneConfig.cpp<br />

src/services/magnatune/MagnatuneConfigWidget.ui<br />

src/services/magnatune/MagnatuneDatabaseHandler.cpp<br />

src/services/magnatune/MagnatuneDatabaseWorker.cpp<br />

src/services/magnatune/MagnatuneDownloadDialog.cpp<br />

src/services/magnatune/MagnatuneDownloadDialog.h<br />

src/services/magnatune/MagnatuneDownloadHandler.cpp<br />

src/services/magnatune/MagnatuneDownloadInfo.cpp<br />

src/services/magnatune/MagnatuneInfoParser.cpp<br />

src/services/magnatune/MagnatuneMeta.cpp<br />

src/services/magnatune/MagnatuneMeta.h<br />

src/services/magnatune/MagnatuneNeedUpdateWidget.cpp<br />

src/services/magnatune/MagnatuneRedownloadDialog.cpp<br />

src/services/magnatune/MagnatuneRedownloadDialog.h<br />

src/services/magnatune/MagnatuneRedownloadHandler.cpp<br />

src/services/magnatune/MagnatuneRedownloadHandler.h<br />

src/services/magnatune/MagnatuneSettingsModule.cpp<br />

src/services/magnatune/MagnatuneStore.cpp<br />

src/services/magnatune/MagnatuneStore.h<br />

src/services/magnatune/MagnatuneUrlRunner.cpp<br />

src/services/magnatune/MagnatuneXmlParser.cpp<br />

src/services/magnatune/amarok_service_magnatunestore.desktop<br />

src/services/mp3tunes/CMakeLists.txt<br />

src/services/mp3tunes/Mp3tunesConfig.cpp<br />

src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp<br />

src/services/mp3tunes/Mp3tunesMeta.cpp<br />

src/services/mp3tunes/Mp3tunesMeta.h<br />

src/services/mp3tunes/Mp3tunesService.cpp<br />

src/services/mp3tunes/Mp3tunesServiceCollection.cpp<br />

src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp<br />

src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp<br />

src/services/mp3tunes/Mp3tunesSettingsModule.cpp<br />

src/services/mp3tunes/Mp3tunesWorkers.cpp<br />

src/services/mp3tunes/Mp3tunesWorkers.h<br />

src/services/mp3tunes/amarok_service_mp3tunes.desktop<br />

src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp<br />

src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.h<br />

src/services/mp3tunes/harmonydaemon/main.cpp<br />

src/services/opmldirectory/AddOpmlWidget.ui<br />

src/services/opmldirectory/CMakeLists.txt<br />

src/services/opmldirectory/OpmlDirectoryInfoParser.cpp<br />

src/services/opmldirectory/OpmlDirectoryInfoParser.h<br />

src/services/opmldirectory/OpmlDirectoryMeta.h<br />

src/services/opmldirectory/OpmlDirectoryModel.cpp<br />

src/services/opmldirectory/OpmlDirectoryModel.h<br />

src/services/opmldirectory/OpmlDirectoryService.cpp<br />

src/services/opmldirectory/OpmlDirectoryService.h<br />

src/services/opmldirectory/OpmlDirectoryView.cpp<br />

src/services/opmldirectory/amarok_service_opmldirectory.desktop</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber<br /></div>