D11867: Logger overhaul

Malte Veerman noreply at phabricator.kde.org
Sun Apr 1 16:39:20 UTC 2018


malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  This moves ProxyLoggers functionality to the Logger base class and makes all important public functions static. Those functions then deliver the to be logged events to all objects of classes derived from Logger. This allows Amarok to have multiple Loggers. 
  I also added a DebugLogger which only gets build in debug mode and prints infos about all logged events to the console.

REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11867

AFFECTED FILES
  src/App.cpp
  src/CMakeLists.txt
  src/EngineController.cpp
  src/browsers/BrowserDock.cpp
  src/browsers/BrowserMessageArea.cpp
  src/browsers/BrowserMessageArea.h
  src/core-impl/collections/daap/DaapCollection.cpp
  src/core-impl/collections/db/sql/SqlCollectionLocation.cpp
  src/core-impl/collections/ipodcollection/IpodCollection.cpp
  src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp
  src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp
  src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp
  src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.cpp
  src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp
  src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp
  src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp
  src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.cpp
  src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp
  src/core-impl/collections/support/FileCollectionLocation.cpp
  src/core-impl/collections/support/TrashCollectionLocation.cpp
  src/core-impl/collections/umscollection/UmsCollection.cpp
  src/core-impl/collections/umscollection/UmsCollectionLocation.cpp
  src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp
  src/core-impl/logger/DebugLogger.cpp
  src/core-impl/logger/DebugLogger.h
  src/core-impl/logger/ProxyLogger.cpp
  src/core-impl/logger/ProxyLogger.h
  src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp
  src/core-impl/playlists/types/file/PlaylistFileSupport.cpp
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp
  src/core/CMakeLists.txt
  src/core/interfaces/Logger.cpp
  src/core/interfaces/Logger.h
  src/core/logger/Logger.cpp
  src/core/logger/Logger.h
  src/core/support/Components.cpp
  src/core/support/Components.h
  src/covermanager/CoverFetcher.cpp
  src/dialogs/TagDialog.cpp
  src/dynamic/BiasedPlaylist.cpp
  src/playlist/PlaylistActions.cpp
  src/playlist/PlaylistRestorer.cpp
  src/playlist/layouts/LayoutManager.cpp
  src/playlistgenerator/ConstraintSolver.cpp
  src/playlistgenerator/Preset.cpp
  src/playlistgenerator/PresetModel.cpp
  src/playlistmanager/PlaylistManager.cpp
  src/playlistmanager/file/PlaylistFileProvider.cpp
  src/scanner/AbstractScanResultProcessor.cpp
  src/scripting/scriptengine/AmarokStatusbarScript.cpp
  src/scripting/scriptmanager/ScriptItem.cpp
  src/scripting/scriptmanager/ScriptManager.cpp
  src/services/ampache/AmpacheAccountLogin.cpp
  src/services/ampache/AmpacheService.cpp
  src/services/gpodder/GpodderProvider.cpp
  src/services/jamendo/JamendoService.cpp
  src/services/jamendo/JamendoXmlParser.cpp
  src/services/lastfm/LastFmService.cpp
  src/services/lastfm/LastFmServiceConfig.cpp
  src/services/lastfm/ScrobblerAdapter.cpp
  src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp
  src/services/lastfm/meta/LastFmMultiPlayableCapability.h
  src/services/magnatune/MagnatuneAlbumDownloader.cpp
  src/services/magnatune/MagnatuneDownloadHandler.cpp
  src/services/magnatune/MagnatuneInfoParser.cpp
  src/services/magnatune/MagnatuneRedownloadHandler.cpp
  src/services/magnatune/MagnatuneStore.cpp
  src/services/magnatune/MagnatuneXmlParser.cpp
  src/services/mp3tunes/Mp3tunesService.cpp
  src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp
  src/services/mp3tunes/Mp3tunesWorkers.cpp
  src/services/opmldirectory/OpmlDirectoryInfoParser.cpp
  src/services/opmldirectory/OpmlDirectoryService.cpp
  src/statemanagement/DefaultApplicationController.cpp
  src/statemanagement/DefaultApplicationController.h
  src/statsyncing/Controller.cpp
  src/statsyncing/Process.cpp
  src/statusbar/LongMessageWidget.h
  tests/core-impl/CMakeLists.txt
  tests/core-impl/collections/db/sql/CMakeLists.txt
  tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp
  tests/core-impl/logger/CMakeLists.txt
  tests/core-impl/logger/TestProxyLogger.cpp
  tests/core-impl/logger/TestProxyLogger.h
  tests/core/CMakeLists.txt
  tests/core/logger/CMakeLists.txt
  tests/core/logger/TestLogger.cpp
  tests/core/logger/TestLogger.h
  tests/mocks/MockLogger.h

To: malteveerman, #amarok
Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20180401/19f57d84/attachment.html>


More information about the Amarok-devel mailing list