<table><tr><td style="">malteveerman created this revision.<br />malteveerman added a reviewer: Amarok.<br />malteveerman added a project: Amarok.<br />malteveerman requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11867">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This moves ProxyLoggers functionality to the Logger base class and makes all important public functions static. Those functions then deliver the to be logged events to all objects of classes derived from Logger. This allows Amarok to have multiple Loggers. <br />

I also added a DebugLogger which only gets build in debug mode and prints infos about all logged events to the console.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R181 Amarok</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11867">https://phabricator.kde.org/D11867</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/App.cpp<br />

src/CMakeLists.txt<br />

src/EngineController.cpp<br />

src/browsers/BrowserDock.cpp<br />

src/browsers/BrowserMessageArea.cpp<br />

src/browsers/BrowserMessageArea.h<br />

src/core-impl/collections/daap/DaapCollection.cpp<br />

src/core-impl/collections/db/sql/SqlCollectionLocation.cpp<br />

src/core-impl/collections/ipodcollection/IpodCollection.cpp<br />

src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp<br />

src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp<br />

src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp<br />

src/core-impl/collections/ipodcollection/jobs/IpodDeleteTracksJob.cpp<br />

src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp<br />

src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp<br />

src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp<br />

src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.cpp<br />

src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp<br />

src/core-impl/collections/support/FileCollectionLocation.cpp<br />

src/core-impl/collections/support/TrashCollectionLocation.cpp<br />

src/core-impl/collections/umscollection/UmsCollection.cpp<br />

src/core-impl/collections/umscollection/UmsCollectionLocation.cpp<br />

src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp<br />

src/core-impl/logger/DebugLogger.cpp<br />

src/core-impl/logger/DebugLogger.h<br />

src/core-impl/logger/ProxyLogger.cpp<br />

src/core-impl/logger/ProxyLogger.h<br />

src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp<br />

src/core-impl/playlists/types/file/PlaylistFileSupport.cpp<br />

src/core-impl/podcasts/sql/SqlPodcastProvider.cpp<br />

src/core/CMakeLists.txt<br />

src/core/interfaces/Logger.cpp<br />

src/core/interfaces/Logger.h<br />

src/core/logger/Logger.cpp<br />

src/core/logger/Logger.h<br />

src/core/support/Components.cpp<br />

src/core/support/Components.h<br />

src/covermanager/CoverFetcher.cpp<br />

src/dialogs/TagDialog.cpp<br />

src/dynamic/BiasedPlaylist.cpp<br />

src/playlist/PlaylistActions.cpp<br />

src/playlist/PlaylistRestorer.cpp<br />

src/playlist/layouts/LayoutManager.cpp<br />

src/playlistgenerator/ConstraintSolver.cpp<br />

src/playlistgenerator/Preset.cpp<br />

src/playlistgenerator/PresetModel.cpp<br />

src/playlistmanager/PlaylistManager.cpp<br />

src/playlistmanager/file/PlaylistFileProvider.cpp<br />

src/scanner/AbstractScanResultProcessor.cpp<br />

src/scripting/scriptengine/AmarokStatusbarScript.cpp<br />

src/scripting/scriptmanager/ScriptItem.cpp<br />

src/scripting/scriptmanager/ScriptManager.cpp<br />

src/services/ampache/AmpacheAccountLogin.cpp<br />

src/services/ampache/AmpacheService.cpp<br />

src/services/gpodder/GpodderProvider.cpp<br />

src/services/jamendo/JamendoService.cpp<br />

src/services/jamendo/JamendoXmlParser.cpp<br />

src/services/lastfm/LastFmService.cpp<br />

src/services/lastfm/LastFmServiceConfig.cpp<br />

src/services/lastfm/ScrobblerAdapter.cpp<br />

src/services/lastfm/meta/LastFmMultiPlayableCapability.cpp<br />

src/services/lastfm/meta/LastFmMultiPlayableCapability.h<br />

src/services/magnatune/MagnatuneAlbumDownloader.cpp<br />

src/services/magnatune/MagnatuneDownloadHandler.cpp<br />

src/services/magnatune/MagnatuneInfoParser.cpp<br />

src/services/magnatune/MagnatuneRedownloadHandler.cpp<br />

src/services/magnatune/MagnatuneStore.cpp<br />

src/services/magnatune/MagnatuneXmlParser.cpp<br />

src/services/mp3tunes/Mp3tunesService.cpp<br />

src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp<br />

src/services/mp3tunes/Mp3tunesWorkers.cpp<br />

src/services/opmldirectory/OpmlDirectoryInfoParser.cpp<br />

src/services/opmldirectory/OpmlDirectoryService.cpp<br />

src/statemanagement/DefaultApplicationController.cpp<br />

src/statemanagement/DefaultApplicationController.h<br />

src/statsyncing/Controller.cpp<br />

src/statsyncing/Process.cpp<br />

src/statusbar/LongMessageWidget.h<br />

tests/core-impl/CMakeLists.txt<br />

tests/core-impl/collections/db/sql/CMakeLists.txt<br />

tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp<br />

tests/core-impl/logger/CMakeLists.txt<br />

tests/core-impl/logger/TestProxyLogger.cpp<br />

tests/core-impl/logger/TestProxyLogger.h<br />

tests/core/CMakeLists.txt<br />

tests/core/logger/CMakeLists.txt<br />

tests/core/logger/TestLogger.cpp<br />

tests/core/logger/TestLogger.h<br />

tests/mocks/MockLogger.h</div></div></div><br /><div><strong>To: </strong>malteveerman, Amarok<br /><strong>Cc: </strong>Amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker<br /></div>