Review Request 129192: Add namespace to desktop and appdata files

[Luigi Toscano]

> On Feb. 23, 2017, 2:04 p.m., Matěj Laitl wrote:
> > Ah, sorry for inactivity. Issue dropped.
> > 
> > OTOH I'm still thinking about value/risk of this change. Pro: according to standards. Con: existing .desktop links may stop working. Has anyone tested this for example with Amarok shortcut in panel, desktop in various DEs? Others, what do you think?

A link in the Plasma panel created with the old name will point to a non-existing desktop file.
Same for a link created into to the desktop (but not if the desktop is copied).
About the standards: the risk is having bugs coming from downstream distributions if the appstream checks are enforced.
On the other side, if 2.9 is going to be released soon, the change could go to the kf5 branch only (as I guess that whatever will happen after 2.9, there won't be new kdelibs4 versions). I'd still prefer to fix it now (with 2.9 going out "soon") than wait for the future Frameworks version.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review102578
-----------------------------------------------------------


On Ott. 16, 2016, 4:12 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
> 
> (Updated Ott. 16, 2016, 4:12 p.m.)
> 
> 
> Review request for Amarok and Matthias Klumpp.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> - add the organization namespace to the desktop and then appdata files, according the specification;
> - use the new directory for metadata (metainfo) files.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 327ec10 
>   src/amarok.appdata.xml c580fd5 
>   src/amarok.desktop  
>   src/amarok_containers.desktop  
>   src/dbus/mpris2/MediaPlayer2.cpp a1d1bda 
> 
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
> 
> 
> Testing
> -------
> 
> Compiles, the files are installed in the expected places.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20170226/f55b9101/attachment.html>