Review Request 129192: Add namespace to desktop and appdata files

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review102578
-----------------------------------------------------------



Ah, sorry for inactivity. Issue dropped.

OTOH I'm still thinking about value/risk of this change. Pro: according to standards. Con: existing .desktop links may stop working. Has anyone tested this for example with Amarok shortcut in panel, desktop in various DEs? Others, what do you think?

- Matěj Laitl


On Říj. 16, 2016, 4:12 odp., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
> 
> (Updated Říj. 16, 2016, 4:12 odp.)
> 
> 
> Review request for Amarok and Matthias Klumpp.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> - add the organization namespace to the desktop and then appdata files, according the specification;
> - use the new directory for metadata (metainfo) files.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 327ec10 
>   src/amarok.appdata.xml c580fd5 
>   src/amarok.desktop  
>   src/amarok_containers.desktop  
>   src/dbus/mpris2/MediaPlayer2.cpp a1d1bda 
> 
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
> 
> 
> Testing
> -------
> 
> Compiles, the files are installed in the expected places.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20170223/b7774844/attachment.html>