Review Request 127523: Only link with MYSQL_EMBEDDED_LIBRARIES if WITH_MYSQL_EMBEDDED

[Matt Whitlock]

> On March 29, 2016, 6:48 p.m., Myriam Schweingruber wrote:
> > hm, I fail to see why you would not build amarok with MySQL embedded, as that is the default database. Could you please specify why this patch is needed?
> 
> Matt Whitlock wrote:
>     Gentoo's philosophy is all about lean-and-mean, compiling support only for those options that one actually uses. There is not "one size fits all," and all users build all software from source, using the configure flags best suited to their needs. The Gentoo ebuild for Amarok has a USE flag "embedded" that enables or disables support for MySQL Embedded using `-DWITH_MYSQL_EMBEDDED` on the CMake command line. I have been running an Amarok built without MySQL Embedded for many years, as I run a full MySQL daemon on my system at all times anyway. The latest Amarok beta no longer builds successfully when MySQL Embedded is disabled. This patch is straightforward and logical and seems to be the obvious way to correct the build problem. (Indeed, I am listening to music in Amarok 2.8.90 right now that has been compiled without MySQL Embedded support by applying this patch to the build system.)
> 
> Myriam Schweingruber wrote:
>     Well, then apply the patch to Gentoo, but why should we change what has always been the default, namely MySQL embedded? We leave it to the users if they want to use an external MySQL server, but that is not the default setup, default definitely is and always has been the embedded version. The external MySQL setup is entirely up to the users discretion, and not the default one.
>     Understand me well: if distributions think they want to change this, it's up to them, but it is not our default setup, so I see no reason to change this in our source.
> 
> Stefano Pettini wrote:
>     Exactly because of this reason, the mechanism that allows users/distributions to select whether to compile with/without the embedded MySQL should work. And the patch fixes this mechanism, that aparently doesn't work. Nobody is trying to change the default.

Gentoo's Amarok ebuild even defaults to USE="+embedded", which enables support for MySQL Embedded. But the point is that it's a user-configurable option (exposing the upstream build configuration option), and both possible values of the option ought to result in a successful build (or else the option ought to be removed). But I see no reason to remove the option when it's easy to fix it so that it works correctly.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127523/#review94120
-----------------------------------------------------------


On March 29, 2016, 12:27 p.m., Matt Whitlock wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127523/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 12:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This patch corrects a build failure when compiling Amarok without MySQL Embedded.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt 244cde1 
> 
> Diff: https://git.reviewboard.kde.org/r/127523/diff/
> 
> 
> Testing
> -------
> 
> See [Gentoo bug 566980](https://bugs.gentoo.org/show_bug.cgi?id=566980).
> 
> 
> Thanks,
> 
> Matt Whitlock
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160330/c76a0cf9/attachment.html>